-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare release r1.1 #190
Prepare release r1.1 #190
Conversation
@akoshunyadi Could you please change the release number to r1.1? See "API release numbers start at r1.1" within https://github.com/camaraproject/ReleaseManagement/blob/main/documentation/API_Release_Guidelines.md I know that the sub project have done a release r0.6 previously, but now it is time to start into the numbering of the Fall24 release cycle ;-) r1.2 could also be an option, to show that it is already the second release within the current cycle. |
README.md
Outdated
@@ -27,11 +27,11 @@ Repository to describe, develop, document and test the DeviceStatus API family | |||
* Note: Please be aware that the project will have frequent updates to the main branch. There are no compatibility guarantees associated with code in any branch, including main, until a new release is created. For example, changes may be reverted before a release is created. **For best results, use the latest available public release**. | |||
|
|||
<!-- following part left in for now but could be omitted going forward --> | |||
* The latest available release version 0.6 (with API version 0.6.0-alpha.1) is available [here](https://github.com/camaraproject/DeviceStatus/tree/r0.6) | |||
* The latest available release is the [version 1.1](https://github.com/camaraproject/DeviceStatus/tree/r1.1) |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
yes, I would wait until all PRs are merged, and the change-log is final |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akoshunyadi Done the review on behalf of Release Management in context of camaraproject/ReleaseManagement#57
Still found some points ;-)
Please update also the release tracker pages at https://wiki.camaraproject.org/display/CAM/DeviceStatus+API+Release+Tracking
Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from ReleaseManagement view - suppose we are done here.
@camaraproject/device-status_codeowners the PR needs a new codeowner review before it can be merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Github is not letting me make suggestions for the "Scope" section in the README, but I'd suggest putting the different functions in different bullet points. e.g.:
|
The reason is that these lines are not changed by the PR. As this is also not within the scope of this PR, how about propose it in an issue and address it when some more Codeowners are again available? (it can perfectly done between RC and public release) |
What type of PR is this?
What this PR does / why we need it:
Prepare the release 1.1
Which issue(s) this PR fixes:
Special notes for reviewers:
Changelog input
Additional documentation