Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release r1.1 #190

Merged
merged 35 commits into from
Aug 2, 2024

Conversation

akoshunyadi
Copy link
Collaborator

@akoshunyadi akoshunyadi commented Jul 15, 2024

What type of PR is this?

  • subproject management

What this PR does / why we need it:

Prepare the release 1.1

Which issue(s) this PR fixes:

Special notes for reviewers:

Changelog input

Additional documentation

@hdamker
Copy link
Contributor

hdamker commented Jul 18, 2024

@akoshunyadi Could you please change the release number to r1.1? See "API release numbers start at r1.1" within https://github.com/camaraproject/ReleaseManagement/blob/main/documentation/API_Release_Guidelines.md

I know that the sub project have done a release r0.6 previously, but now it is time to start into the numbering of the Fall24 release cycle ;-) r1.2 could also be an option, to show that it is already the second release within the current cycle.

@akoshunyadi akoshunyadi changed the title Prepare release r0.7 Prepare release r1.1 Jul 23, 2024
README.md Outdated
@@ -27,11 +27,11 @@ Repository to describe, develop, document and test the DeviceStatus API family
* Note: Please be aware that the project will have frequent updates to the main branch. There are no compatibility guarantees associated with code in any branch, including main, until a new release is created. For example, changes may be reverted before a release is created. **For best results, use the latest available public release**.

<!-- following part left in for now but could be omitted going forward -->
* The latest available release version 0.6 (with API version 0.6.0-alpha.1) is available [here](https://github.com/camaraproject/DeviceStatus/tree/r0.6)
* The latest available release is the [version 1.1](https://github.com/camaraproject/DeviceStatus/tree/r1.1)

This comment was marked as resolved.

README.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@akoshunyadi
Copy link
Collaborator Author

@akoshunyadi consider to add @camaraproject/release-management_maintainers as reviewers if the PR is there.

yes, I would wait until all PRs are merged, and the change-log is final

bigludo7
bigludo7 previously approved these changes Jul 26, 2024
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@hdamker hdamker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akoshunyadi Done the review on behalf of Release Management in context of camaraproject/ReleaseManagement#57

Still found some points ;-)

Please update also the release tracker pages at https://wiki.camaraproject.org/display/CAM/DeviceStatus+API+Release+Tracking

CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
hdamker
hdamker previously approved these changes Jul 26, 2024
Copy link
Contributor

@hdamker hdamker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from ReleaseManagement view - suppose we are done here.

@camaraproject/device-status_codeowners the PR needs a new codeowner review before it can be merged

Copy link
Contributor

@maxl2287 maxl2287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CHANGELOG.md Outdated Show resolved Hide resolved
@eric-murray
Copy link
Collaborator

Github is not letting me make suggestions for the "Scope" section in the README, but I'd suggest putting the different functions in different bullet points. e.g.:

  • It provides the customer with the ability to:
    • check if a device is reachable or has lost connection to the network
    • check the roaming status of a device, and which network it is roaming on
    • receive notifications if the status of the device changes

@hdamker
Copy link
Contributor

hdamker commented Jul 31, 2024

Github is not letting me make suggestions for the "Scope" section in the README, but I'd suggest putting the different functions in different bullet points

The reason is that these lines are not changed by the PR. As this is also not within the scope of this PR, how about propose it in an issue and address it when some more Codeowners are again available? (it can perfectly done between RC and public release)

@akoshunyadi akoshunyadi merged commit 24e85f7 into camaraproject:main Aug 2, 2024
1 check passed
@akoshunyadi akoshunyadi deleted the prepare-release-r0.7 branch September 30, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants