Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

worse than locked queue #399

Open
396848385 opened this issue Oct 10, 2024 · 6 comments
Open

worse than locked queue #399

396848385 opened this issue Oct 10, 2024 · 6 comments

Comments

@396848385
Copy link

I tried using this lock free queue in our program, but the performance of the task was even worse.

Our program scenario involves multiple queues, each with a fixed number of elements. After an element is retrieved by wait_dequeue, the program performs other operations and then enqueues the element. The purpose of this is to avoid repeatedly creating objects or to block threads in some scenarios to prevent too many threads from executing a logic at the same time

What I want to know is why the performance of this lock free queue is worse than the locked queue that our program already has

@cameron314
Copy link
Owner

Hard to say why without sample code to investigate.

@396848385
Copy link
Author

image
like this

@396848385
Copy link
Author

and this
image

@cameron314
Copy link
Owner

That's a start. I see you're using integers. Are you using tokens? What sort of contention is there?

@396848385
Copy link
Author

Only a very few scenarios use integer
no using tokens.
Basically, it's the same usage as the two images above, but after using this lock free queue, my training task time has greatly increased. Do you know what possible reasons are causing this

@cameron314
Copy link
Owner

For the non-integer types, do they have no-except move constructors? Are they being moved? Consider using producer and consumer tokens. I also encourage you to profile the code to see where the overhead is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants