From 9487b88bfcafb89d5efcd44caab1c36befe3c884 Mon Sep 17 00:00:00 2001
From: Vedant  Nandoskar <vedant.nandoskar@gmail.com>
Date: Tue, 28 Apr 2020 22:46:35 +0530
Subject: [PATCH] Signup Conditional for Temporarily Disabled Security (#388)

* Fixed typo for return

* Fix for refresh during first slide upload

* Fixed refresh on first slide upload

* Added space after 'if'  for eslint configuration

* Added functionality to delete slide from system

* Removed refresh on first slide upload

* Added alert for slide deletion success

* Update to fix linting errors

* Update to fix linting errors

* Fix linting errors

* Fix lint errors

* Fix lint error

* Rechained promises to handle mishandled slide deletions

* style fix

* Added delete slide request functionality

* style fix

* style fix

* style fix

* style fix

* style fix

* Client side changes for handling new 'requests' collection

* merge fix

* merge fix

* Fix for direct deletion of slides

* style fix

* Added feature for user registration requests

* style fix

* Commented line stating that signup page is just for admins

* Added line explaining new workflow of signup page

* Added popups for success instead of alerts and moved showSuccessPopup to util.js for reusability

* Comment fix

* Style fix

* Solved permsisions is not defined error in signup.html

* Comment fix

* catch promise error

Co-Authored-By: Ryan Birmingham <birm@rbirm.us>

* error handling on fetching requests

Co-Authored-By: Ryan Birmingham <birm@rbirm.us>

* Update apps/table.html

* modifications for handling prototype

* removed unwanted console.logs

* Update functions to handle first time user registrations

* Fix to a missing .html extension

Co-authored-by: Ryan Birmingham <birm@rbirm.us>
---
 apps/signup/signup.html | 107 +++++++++++++++++++++++++++++-----------
 apps/table.css          |   2 +-
 login.html              |   2 +-
 3 files changed, 79 insertions(+), 32 deletions(-)

diff --git a/apps/signup/signup.html b/apps/signup/signup.html
index 73e08b3bd..0f180645a 100644
--- a/apps/signup/signup.html
+++ b/apps/signup/signup.html
@@ -36,7 +36,8 @@
 
   </head>
   <script>
-    var userSignupUrl = "../../data/User/post"
+    var userSignupUrl = "../../data/User/post";
+    var protoTokenUrl = "../../auth/Token/proto";
     var permissions;
 
     function addUser(){
@@ -52,34 +53,80 @@
       if (attr == "2"){
         userType = "Editor"
       }
-      // if (getUserType() === "Admin") {
-      if (permissions.user.post == true) {
-        var doc = {email: email, userType: userType, userFilter:filters}
-        fetch(userSignupUrl, {
-            method: 'POST',
-            mode: 'cors', // no-cors, cors, *same-origin
-            cache: 'no-cache', // *default, no-cache, reload, force-cache, only-if-cached
-            credentials: 'same-origin', // include, *same-origin, omit
-            headers: {
-                'Content-Type': 'application/json',
-            },
-            body: JSON.stringify(doc),
-          }).then(x=>{
-            if (x.status>=400){
-              throw "failed to sign up user"
-            }
-            x.json()
-          }).then(x=>{
-            window.alert("User registered successfully")
-            console.log(x)
-          }).catch(e=>{
-            // window.alert("error!")
-            console.error(e)
-        });
-      } else {
-        const store = new Store('../data/');
-        store.requestToCreateUser(email, filters, userType);
-      }
+
+      getUserPermissions(getUserType())
+        .then(response => response.text())
+        .then((data) => {
+        return (data ? JSON.parse(data) : null);
+        })
+        .then((data)=> {
+            if(data===null)
+                return;
+            permissions = data;
+            return;
+      })
+      .then((resp) => {
+        return fetch(protoTokenUrl)
+      })
+      .then((response) => {
+        // console.log(response);
+        return response.json();
+      })
+      .then((data) => {
+        return data.exists
+      })
+      .then((x) => {
+        if (x) {
+          var doc = {email: email, userType: userType, userFilter:filters}
+          fetch(userSignupUrl, {
+              method: 'POST',
+              mode: 'cors', // no-cors, cors, *same-origin
+              cache: 'no-cache', // *default, no-cache, reload, force-cache, only-if-cached
+              credentials: 'same-origin', // include, *same-origin, omit
+              headers: {
+                  'Content-Type': 'application/json',
+              },
+              body: JSON.stringify(doc),
+            }).then(x=>{
+              if (x.status>=400){
+                throw "failed to sign up user"
+              }
+              x.json()
+            }).then(x=>{
+              window.alert("User registered successfully")
+            }).catch(e=>{
+              // window.alert("error!")
+              console.error(e)
+          });
+        } else {
+          if (permissions.user && permissions.user.post == true) {
+            var doc = {email: email, userType: userType, userFilter:filters}
+            fetch(userSignupUrl, {
+                method: 'POST',
+                mode: 'cors', // no-cors, cors, *same-origin
+                cache: 'no-cache', // *default, no-cache, reload, force-cache, only-if-cached
+                credentials: 'same-origin', // include, *same-origin, omit
+                headers: {
+                    'Content-Type': 'application/json',
+                },
+                body: JSON.stringify(doc),
+              }).then(x=>{
+                if (x.status>=400){
+                  throw "failed to sign up user"
+                }
+                x.json()
+              }).then(x=>{
+                window.alert("User registered successfully");
+              }).catch(e=>{
+                // window.alert("error!")
+                console.error(e)
+            });
+          } else {
+            const store = new Store('../data/');
+            store.requestToCreateUser(email, filters, userType);
+          }
+        }
+      });
     }
 
     $(window).on('load', function() {
@@ -95,7 +142,7 @@
             if(data===null)
                 return;
             permissions = data;
-      })
+      });
     });
 
   </script>
diff --git a/apps/table.css b/apps/table.css
index 331dacbd6..fb95744e1 100644
--- a/apps/table.css
+++ b/apps/table.css
@@ -155,4 +155,4 @@ nav li:not(.active):hover a{
 
 .collapse.in {
 	 display: inline !important;
-}
\ No newline at end of file
+}
diff --git a/login.html b/login.html
index 05602aaa0..d221ad3de 100644
--- a/login.html
+++ b/login.html
@@ -65,7 +65,7 @@
         window.location = state
       } else {
         window.alert("User not added")
-        window.location = "./apps/signup/signup"
+        window.location = "./apps/signup/signup.html"
       }
 
     })