Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to decide to accept a PR. #3

Closed
DavidSagan opened this issue Oct 30, 2024 · 1 comment
Closed

How to decide to accept a PR. #3

DavidSagan opened this issue Oct 30, 2024 · 1 comment

Comments

@DavidSagan
Copy link
Contributor

We need to settle on how PRs are accepted (merged). My proposal is this:

  • If a PR is represents a "trivial" change, that is, the PR only does something like correct grammar, then the PR can be accepted by any of the "maintainers" designated by the community.
  • If the PR involves code changes (for example to a particular translation program), the people who are maintaining the code will decide by consensus whether to accept or not.
  • For other PRs, I propose that acceptance would need a 75% approval vote. I put the bar high here since if there is significant objection to a PR, there can always be more discussion. In fact I would be open to using a higher percentage here at least to try out.

Comments anyone?

@ax3l
Copy link
Member

ax3l commented Jan 8, 2025

Part of the #7 . Solved.

@ax3l ax3l closed this as completed Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants