Specifying Bloodhunter's Patron

[kompoth]

I am trying to generate a Bloodhunter of the Order of the Profane Soul and can't figure out how to select a Patron. I see that patron option is a FeatureSelector, just like a Fighting Style, so it seemed logical that patron should be specified the same way:

classes = ['Blood hunter']
levels = [3]
subclasses = ['Order of the Profane Soul']
...
features = ('Crossbow Expert')
feature_choices = ('Archery', 'Undying')

This works for Archery, but the Undying still is unspecified in the resulting character sheet. Also tried other options like 'Fiend' (used values from OtherworldlyPatron class).

Is it a bug? Thank you.

[canismarko]

Hi, there.

Try putting the patron in the subclasses list: subclasses = ["Order of the Profane Soul", "Undying"]

This is how warlocks handle patron features: https://github.com/canismarko/dungeon-sheets/blob/master/examples/warlock1.py

I haven't tested it with Bloodhunters, so please let me know if that works.

[kompoth]

Thank you for quick response! Yes, I tried this and got an exception: class and subclass lists must have equal sizes, here - character.py:258 ср, 27 июл. 2022 г., 19:17 Mark Wolfman ***@***.***>:

…

Hi, there. Try putting the patron in the subclasses list: subclasses = ["Order of the Profane Soul", "Undying"] This is how warlocks handle patron features: https://github.com/canismarko/dungeon-sheets/blob/master/examples/warlock1.py I haven't tested it with Bloodhunters, so please let me know if that works. — Reply to this email directly, view it on GitHub <#134 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJ6PBQOZF3DVIQ3QFZHAE5DVWFOJ7ANCNFSM54ZYQV7Q> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[canismarko]

Ah, yeah I think I understand the problem.

Patrons were initially included for Warlocks, and apparently the subclasses became the Patrons, but I think this is incorrect. I think Pact Boon is actually what it should be since it occurs at lvl 3 just like all the other classes. If we made the patron at feature choice like you selected then Pact of the Whatever became the subclass, I think it would all work properly for BloodHunter classes as well.

That would be a breaking change, so it will take some careful thought. I'll work on it when I have some free time, unless you feel motivated to submit a PR.

[canismarko]

Note to self: make sure to include spells and damage resistances from #135

[PJBrs]

The options need to be non-capitalized in dungeonsheets/features/bloodhunter.py:

diff --git a/dungeonsheets/features/bloodhunter.py b/dungeonsheets/features/bloodhunter.py
index 9d6f943..f6a5c21 100644
--- a/dungeonsheets/features/bloodhunter.py
+++ b/dungeonsheets/features/bloodhunter.py
@@ -1102,12 +1102,12 @@ class OtherworldlyPatron(FeatureSelector):
     """
 
     options = {
-       "Archfey": ArchfeyPatron,
-       "Celestial": CelestialPatron,
-       "Fiend": FiendPatron,
-       "Great Old One": GreatOldOnePatron,
-       "Hexblade": HexbladePatron,
-       "Undying": UndyingPatron,
+        "archfey": ArchfeyPatron,
+        "celestial": CelestialPatron,
+        "fiend": FiendPatron,
+        "great old one": GreatOldOnePatron,
+        "hexblade": HexbladePatron,
+        "undying": UndyingPatron,
     }
     name = "Otherworldly Patron (Select One)"
     source = "Blood Hunter (Order of the Profane Soul)"

I've added this patch to the following commit
cd9e7d4

[canismarko]

@PJBrs Ah interesting. Somewhere then there must a str.lower() call, right?

Thanks for implementing that fix. Could it be a separate PR instead of getting lumped into those other ones? They're already complicated enough that I don't have bandwidth to process them, and adding more stuff makes that worse. Ideally, each PR would address one thing, like multiple issues are mutually related or something.

[PJBrs]

Over here: #167