Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use platform for build environment names #600

Closed
mr-cal opened this issue Jan 6, 2025 · 2 comments · Fixed by #601
Closed

Use platform for build environment names #600

mr-cal opened this issue Jan 6, 2025 · 2 comments · Fixed by #601
Labels
Enhancement New feature or request triaged

Comments

@mr-cal
Copy link
Contributor

mr-cal commented Jan 6, 2025

What needs to get done

Change the instance naming convention from:

<app>-<project>-on-<build-on>-for-<build-for>-<project-dir-inode>

to:

<app>-<project>-<platform>-<project-dir-inode>

Why it needs to get done

To avoid the same instance getting used for different builds.

Example

Currently, these use the same build environment:

platforms:
  noble:
      build-on: amd64
      build-for: amd64
  noble-debug:
      build-on: amd64
      build-for: amd64

This is also a problem for multi-base recipes (canonical/charmcraft#2058).

@mr-cal mr-cal added Enhancement New feature or request triaged labels Jan 6, 2025
Copy link

Thank you for reporting your feedback to us!

The internal ticket has been created: https://warthogs.atlassian.net/browse/CRAFT-3859.

This message was autogenerated

Copy link

Thank you for reporting your feedback to us!

The internal ticket has been created: https://warthogs.atlassian.net/browse/CRAFT-3858.

This message was autogenerated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant