Skip to content

Commit 5b6c85b

Browse files
authored
fix(ci): Run tests in testing namespace and add logging (#253)
* fix(ci): Run tests in `testing` namespace and add logging * pass {posargs} Closes #252
1 parent 5803946 commit 5b6c85b

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

.github/workflows/integrate.yaml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,12 +88,16 @@ jobs:
8888
charmcraft-channel: 3.x/stable
8989

9090
- run: |
91-
sg snap_microk8s -c "tox -e ${{ matrix.charm }}-integration"
91+
sg snap_microk8s -c "tox -e ${{ matrix.charm }}-integration -- -- --model testing"
9292
9393
# Collect debug logs if failed
9494
- name: Dump Juju/k8s logs on failure
9595
uses: canonical/kubeflow-ci/actions/dump-charm-debug-artifacts@main
96-
if: always()
96+
if: failure()
97+
98+
- name: Dump logs
99+
if: failure()
100+
uses: canonical/charming-actions/dump-logs@2.6.3
97101

98102
test-bundle:
99103
name: Test the bundle

tox.ini

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ setenv =
2323
lint: TYPE = lint
2424
integration: TYPE = integration
2525
commands =
26-
tox -c charms/katib-{env:CHARM} -e {env:TYPE}
26+
tox -c charms/katib-{env:CHARM} -e {env:TYPE} {posargs}
2727

2828
[testenv:update-requirements]
2929
allowlist_externals =
@@ -66,4 +66,4 @@ description = Check code against coding style standards
6666
[testenv:bundle-integration]
6767
commands = pytest -v --tb native --show-capture=no --log-cli-level=INFO -s {posargs} {toxinidir}/tests/integration
6868
deps =
69-
-r requirements-integration.txt
69+
-r requirements-integration.txt

0 commit comments

Comments
 (0)