[DPE-2565] Open port #159
[DPE-2565] Open port #159
Conversation
| namespace=service.metadata.namespace, | ||
| force=True, | ||
| field_manager=self.app.name, | ||
| patch_type=lightkube.types.PatchType.MERGE, |
There was a problem hiding this comment.
We need to merge to update the port when it changes. This nukes the placeholder port that's currently added to the service by default.
There was a problem hiding this comment.
Do we need a placeholder port 65535 (since we declare the real one)?
There was a problem hiding this comment.
From what I understood from here, 65535 is not needed (it was needed only to create the service, but now we have another port).
There was a problem hiding this comment.
LGTM.
Please mention in PR message: Close #140
P.S. IMHO we do not need placeholder port anymore => no need to merge.
E.g. postgresql services have no placeholder ports, the same for patroni.
ubuntu@juju31:~$ kubectl get services -A
NAMESPACE NAME TYPE CLUSTER-IP EXTERNAL-IP PORT(S) AGE
...
test18 postgresql-k8s ClusterIP 10.152.183.17 <none> 5432/TCP,8008/TCP 25h
test18 postgresql-k8s-primary ClusterIP 10.152.183.140 <none> 8008/TCP,5432/TCP 25h
test18 postgresql-k8s-replicas ClusterIP 10.152.183.215 <none> 8008/TCP,5432/TCP 25h
test18 patroni-postgresql-k8s-config ClusterIP None <none> <none> 25h
P.S. Juju creates it here (and never used further).
| namespace=service.metadata.namespace, | ||
| force=True, | ||
| field_manager=self.app.name, | ||
| patch_type=lightkube.types.PatchType.MERGE, |
There was a problem hiding this comment.
Do we need a placeholder port 65535 (since we declare the real one)?
We need to merge, because that will update the pgbouncer port on config change. It will also delete the placeholder port since, it's not in the new port spec. |
| namespace=service.metadata.namespace, | ||
| force=True, | ||
| field_manager=self.app.name, | ||
| patch_type=lightkube.types.PatchType.MERGE, |
There was a problem hiding this comment.
From what I understood from here, 65535 is not needed (it was needed only to create the service, but now we have another port).
Issue
Ports are not patched on the K8s service.
Solution
Use open port call from ops if available, patch directly if not.