Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent icon direction on sortable table #1107

Closed
andesol opened this issue Jul 22, 2024 · 2 comments
Closed

Inconsistent icon direction on sortable table #1107

andesol opened this issue Jul 22, 2024 · 2 comments

Comments

@andesol
Copy link
Contributor

andesol commented Jul 22, 2024

After canonical/vanilla-framework#5135 that inverted the icons on the sortable table, seems like it needs to be updated on the react components as well, otherwise the direction doesn't match.

Compare this example:
https://vanillaframework.io/docs/examples/patterns/tables/table-sortable?theme=light

With this one:
https://canonical.github.io/react-components/?path=/story/components-maintable--sortable

@jmuzina
Copy link
Member

jmuzina commented Sep 11, 2024

I believe this was fixed by #1096 (React Components needed to be updated to use v4.13.0 or later. Previously React Components was using v4.11.0).

@andesol Is this issue still occurring for you?

@andesol
Copy link
Contributor Author

andesol commented Sep 12, 2024

@jmuzina Works consistently now 👍

@andesol andesol closed this as completed Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants