Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement] Ability to override logo in LoginPageLayout #1135

Open
gruyaume opened this issue Sep 18, 2024 · 2 comments
Open

[enhancement] Ability to override logo in LoginPageLayout #1135

gruyaume opened this issue Sep 18, 2024 · 2 comments

Comments

@gruyaume
Copy link

Description

This is an enhancement request to add the ability to override the logo in the LoginPageLayout.

If we want to build a login page that does not have the Canonical branding / orange tag, it's not trivial to do so with the existing LoginPageLayout. The Navigation already has this support and here the request is to do the same for the LoginPageLayout.

@ashish1233
Copy link

ashish1233 commented Sep 26, 2024

hey @gruyaume , i am new here, i was going through your request.

please correct me if i am wrong

It seems like there is an option to override the logo since, as shown in the image below, we have the ability to pass the logo as a prop. However, while reviewing the Storybook and documentation, I couldn't find any reference or example demonstrating this functionality, so is your request to update the story book?

image

@opheliagame
Copy link

@gruyaume @ashish1233
Hi, I started looking at this too and a couple of things bother me currently.

  • OverridingTheLogo Story in Navigation, does successfully override how the logo looks but we lose the functionality of being able to click on the logo and return to the home page.
  • The logo prop being used in Navigation and the one being used in LoginPageLayout is not standardized. Maybe this is to avoid dependencies between these two components, but it does make more sense to me for both of these logos to have the same functionality and provide the same interface.

Would love to hear thoughts on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants