New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feedback from Microverse's The Beagles tea. #1

Open

canriquez opened this issue Oct 5, 2020 · 0 comments

Owner

canriquez commented Oct 5, 2020 •

edited

Loading

1- Great API. Functional and with many edge cases considered.

Suggestions

Consider using an environment variable to give the chance to generate a special SECRET word for the JWT token generation.
Include full API documentation (perhaps in Wiki sections) using a gem like rspec_api_documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment