Write locations to file #81
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've also explored the ability to use a rotating log file in order to make sure this doesn't explode in terms of disk space and it works nicely. |
|
I would leave it to the application to manage the log file, which might include log rotation. It's too much complexity to add to the plugin.
I'm not sure what you mean by this. What is the problem? |
|
I'm not sure how to pass the log file path to the relevant method in iOS. Seems weird to me how the flow of data is done in swift (mainly because I don't know swift I guess)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #80
This is still not complete as I need to support iOS and I'm very new to swift.
Any help there would be greatly appreciated.
Also I'm not sure how to pass the file path there into the location update method so again, help would be appreciated.
I didn't want to add file plugin to the example, but I tested this code to work with my app basically.
Let me know how you want to proceed with this.