feat(common): add retriability signal to Result pattern Err type (#121)#168
Open
b3lz3but wants to merge 1 commit intocaptainpragmatic:masterfrom
Open
feat(common): add retriability signal to Result pattern Err type (#121)#168b3lz3but wants to merge 1 commit intocaptainpragmatic:masterfrom
b3lz3but wants to merge 1 commit intocaptainpragmatic:masterfrom
Conversation
…tainpragmatic#121) Add retriable: bool = False field to the Err dataclass so callers (e.g. Django-Q tasks) can distinguish transient errors (DB timeout, lock contention) from permanent ones (validation failure). Default False preserves backward compatibility with all 577 existing Err() call sites. Closes captainpragmatic#121 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Ciprian Radulescu <craps2003@gmail.com>
Contributor
Author
|
@mostlyvirtual — small arch-debt cleanup, requesting review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
retriable: bool = Falsefield to theErrdataclass so callers can distinguish transient errors (DB timeout, lock contention) from permanent ones (validation failure, business rule violation).Closes #121
Change
Backward compatibility
All 577 existing
Err("message")call sites continue to work unchanged — the defaultretriable=Falseis applied automatically. No migration needed.Usage
Files changed
apps/common/types.py— Addedretriablefield toErrdataclass (+5 lines)tests/common/test_result_types.py— 24 new tests covering Ok/Err behavior and retriable signalTest plan
🤖 Generated with Claude Code