Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modal] modal component is out of order in the left nav list #3955

Closed
1 task done
mbgower opened this issue Feb 29, 2024 · 1 comment · Fixed by #4107
Closed
1 task done

[Modal] modal component is out of order in the left nav list #3955

mbgower opened this issue Feb 29, 2024 · 1 comment · Fixed by #4107

Comments

@mbgower
Copy link
Contributor

mbgower commented Feb 29, 2024

Acceptance criteria

In the component list in the left navigation, Modal follows Loading, and is in turn followed by Menu and Menu Buttons.

I believe technically it is the addition of these last two items that were placed in the wrong order (i.e., they should have been placed BEFORE Modal and were positioned after it by mistake.

  • Place the Modal component after the Menu buttons component in the left hand nav.

Steps to reproduce the issue

  1. Go to https://carbondesignsystem.com/
  2. Expand Components in the left nav
  3. Navigate down to the Ms
  4. Notice Modal is before Menu in the list
image
@mbgower mbgower changed the title Modal is out of order in component list of left navigation; Menu buttons is plural Modal is out of order in component list; Menu buttons is plural Feb 29, 2024
@laurenmrice laurenmrice added this to the 2024 Q1 milestone Mar 13, 2024
@laurenmrice laurenmrice moved this to 🪆 Needs Refined in Design System Mar 13, 2024
@laurenmrice laurenmrice modified the milestones: 2024 Q1, 2024 Q2 Mar 27, 2024
@laurenmrice laurenmrice moved this from 🪆 Needs Refined to ⏱ Backlog in Design System Apr 1, 2024
@laurenmrice laurenmrice changed the title Modal is out of order in component list; Menu buttons is plural [Modal] modal component is out of order in the left nav list Apr 4, 2024
@laurenmrice
Copy link
Member

I split this issue out and put the topic of renaming "Menu buttons" in this issue as a separate topic: #3998

@laurenmrice laurenmrice modified the milestones: 2024 Q2, 2024 Q3 May 22, 2024
@Kritvi-bhatia17 Kritvi-bhatia17 moved this from ⏱ Backlog to 🏗 In Progress in Design System Jun 10, 2024
@Kritvi-bhatia17 Kritvi-bhatia17 moved this from 🏗 In Progress to 🚦 In Review in Design System Jun 11, 2024
@Kritvi-bhatia17 Kritvi-bhatia17 moved this from 🚦 In Review to ✅ Done in Design System Jun 11, 2024
@Kritvi-bhatia17 Kritvi-bhatia17 closed this as completed by moving to ✅ Done in Design System Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants