Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revised first sentence under Typography #4125

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

lesnider
Copy link
Contributor

@lesnider lesnider commented Jun 17, 2024

Closes #

Changed

Notification text should be set in sentence case with only the first word capitalized.

to be more direct and prescriptive:

Write notifications in sentence case, which means only the first word is capitalized.

@lesnider lesnider requested review from a team as code owners June 17, 2024 20:00
Copy link

vercel bot commented Jun 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbondesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 18, 2024 5:50pm

Copy link
Member

@alina-jacob alina-jacob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚀

@lesnider
Copy link
Contributor Author

lesnider commented Jun 18, 2024

Looks good! 🚀

Thanks, @alina-jacob. Looks like it won't merge though. Please see "Some checks were not successful" below.

@tay1orjones
Copy link
Member

I fixed the yarn format check

@lesnider
Copy link
Contributor Author

@tay1orjones Thank you! When can this issue be merged into main?

@kodiakhq kodiakhq bot merged commit a427614 into carbon-design-system:main Jun 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants