Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Homepage] Homepage revamp + Banner change #4137

Merged
merged 5 commits into from
Jul 1, 2024
Merged

[Homepage] Homepage revamp + Banner change #4137

merged 5 commits into from
Jul 1, 2024

Conversation

thyhmdo
Copy link
Member

@thyhmdo thyhmdo commented Jun 24, 2024

Closes ##4057 and ##4058

Updating the homepage with new Carbon AI related elements

Changelog

Changed

  • Banner illustration
  • Resource card illustration for Design, Develop, and Migration
  • 3-row Resource card group for Other resources

@vercel Vercel
Copy link

vercel bot commented Jun 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbondesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 1, 2024 8:20pm

@thyhmdo thyhmdo marked this pull request as ready for review June 27, 2024 13:12
@thyhmdo thyhmdo requested review from a team as code owners June 27, 2024 13:12
@thyhmdo thyhmdo removed the request for review from tay1orjones June 27, 2024 13:12
@alina-jacob
Copy link
Member

Looks awesome @thyhmdo! ❤️ 🚀

@mjabbink
Copy link
Contributor

Did we consider a mobile version?

alisonjoseph
alisonjoseph approved these changes Jun 28, 2024
View reviewed changes
Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. Super minor thing but can you delete the old homepage images that are no longer being used?

I also had a question, is the intention to keep the migrate to v11 resource card, or are we going to add a link to AI once Anna's PR is ready/merged?

@thyhmdo
Copy link
Member Author

thyhmdo commented Jul 1, 2024

This LGTM. Super minor thing but can you delete the old homepage images that are no longer being used?

I also had a question, is the intention to keep the migrate to v11 resource card, or are we going to add a link to AI once Anna's PR is ready/merged?

Yeah I think we should link it to AI

@thyhmdo thyhmdo added this to the 2024 Q3 milestone Jul 1, 2024
@alisonjoseph alisonjoseph enabled auto-merge (squash) July 1, 2024 20:12
@alisonjoseph alisonjoseph merged commit 79695f8 into carbon-design-system:main Jul 1, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeanservaas jeanservaas jeanservaas approved these changes

@alisonjoseph alisonjoseph alisonjoseph approved these changes

@RichKummer RichKummer Awaiting requested review from RichKummer RichKummer is a code owner automatically assigned from carbon-design-system/design

@mjabbink mjabbink Awaiting requested review from mjabbink

Assignees

@thyhmdo thyhmdo

Labels
status: ready to merge 🎉
Projects
Design System
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@thyhmdo @alina-jacob @mjabbink @alisonjoseph @jeanservaas