Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI Content Design Guild] Notification component topic is missing content #4165

Open
lesnider opened this issue Jul 9, 2024 · 10 comments
Open

Comments

@lesnider
Copy link
Contributor

lesnider commented Jul 9, 2024

https://carbondesignsystem.com/components/notification/usage/

Need explicit guidance for creating content for messages (error, information, warning).

@lesnider lesnider changed the title [Notifications component topic] Content guidance missing [UI Content Design Guild] Notifications component topic is missing content Jul 9, 2024
@lesnider
Copy link
Contributor Author

lesnider commented Jul 9, 2024

Related to #4127

@lesnider lesnider changed the title [UI Content Design Guild] Notifications component topic is missing content [UI Content Design Guild] Notification component topic is missing content Jul 9, 2024
@sstrubberg sstrubberg moved this to 🕵️‍♀️ Triage in Design System Jul 9, 2024
@benjamin-kurien benjamin-kurien moved this from 🕵️‍♀️ Triage to 🪆 Needs Refined in Design System Aug 28, 2024
@lesnider
Copy link
Contributor Author

lesnider commented Aug 30, 2024

@sstrubberg @laurenmrice @aagonzales
Hey, Scott, Lauren, and Anna. Here's most of our feedback for the Notification component, which we want to go through with you and other CDSers on Tuesday.
Notification-UIContentGuild-comments+edits.docx

We're also wondering about the error, warning, info, success statuses. We're sure why that's mentioned in the
pattern but not in the Usage tab of this component.

@sstrubberg
Copy link
Member

@lesnider would you humor me and re-submit this request using this form? I'm curious if it will help us with the triage process.

@lesnider
Copy link
Contributor Author

lesnider commented Sep 5, 2024

@lesnider would you humor me and re-submit this request using this form? I'm curious if it will help us with the triage process.

@sstrubberg Hey, Scott. How does this look? #4238

@lesnider
Copy link
Contributor Author

@sstrubberg @alina-jacob I was told to hold off on making content changes to the Notification component topic because it was under construction. May I proceed now, please?

@laurenmrice
Copy link
Member

@lesnider The new content for Notification is still currently in a couple different PRs and has not merged into our live website yet, so I would still hold off on making any new changes to the content until those PRs are merged. We will reach out to you once Notification can be worked on. Thanks!

@laurenmrice
Copy link
Member

laurenmrice commented Nov 27, 2024

@lesnider The PRs on our side are merged and the Notifications Usage tab is up to date on the website. This is available to be worked on now.

I also noticed there is another issue open with this same name here: #4238. Do these need to be separate issues, or can we combine them into one?

@lesnider
Copy link
Contributor Author

@laurenmrice Thanks! I will start working on Notifications this week.

I closed 4238 as a duplicate. No idea how that happened. :)

@lesnider
Copy link
Contributor Author

@laurenmrice I know why there was a duplicate (#4238). @sstrubberg asked me to use a new template (#4165 (comment)) and so I did. Should we reopen 4328 and close this one instead? I have only a few days before vacation, but perhaps I can work on this topic before I leave or as soon as I return.

@sstrubberg What do you think? Should I use this issue or reopen #4238 to open PRs?

@laurenmrice
Copy link
Member

laurenmrice commented Dec 16, 2024

@lesnider If this issue was a duplicate of the original #4238, which is now closed, lets just keep this issue (#4165) open since it is still open and has a thread going in it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🏗 In progress
Status: No status
Development

No branches or pull requests

4 participants