Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map attribute does not show any map #335

Open
3 of 7 tasks
Kitsuneko111 opened this issue Jan 21, 2024 · 1 comment
Open
3 of 7 tasks

Map attribute does not show any map #335

Kitsuneko111 opened this issue Jan 21, 2024 · 1 comment
Assignees
Labels
Bug Something is not working and will need to be fixed.

Comments

@Kitsuneko111
Copy link

Check for existing bug reports before submitting.

  • I searched for existing Bug Reports and found no similar reports.

Expected Behavior

A map would show or an option to add your own map

Current behaviour

It’s just empty

Reproduction

  1. Make a location (example)
  2. Add a location attribute
  3. Map won’t load

Which Operating Systems are you using?

  • Android
  • iPhone/iPad
  • Linux
  • macOS
  • Windows

Obsidian Version Check

1.5.3 and 1.4.16

Plugin Version

4.1.14

Confirmation

  • I have disabled all other plugins and the issue still persists.

Possible solution

React-simple-maps uses fetch which by default wants to do CORS. Between this and the current default url now being invalid as far as I’m able to find, this stops it from loading. Unsure how to fix, but you’d need to add no-cors to the request. Doubt if changing node-modules code is a valid fix.

@Kitsuneko111 Kitsuneko111 added the Bug Something is not working and will need to be fixed. label Jan 21, 2024
@Kitsuneko111
Copy link
Author

Just for some added info, this project uses the second link in the react-simple-map readme which is now a 404 and has been marked by an issue by multiple people on their end. In swapping out the link for the other example one it creates the CORS issue, which may be harder to fix without a fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is not working and will need to be fixed.
Projects
None yet
Development

No branches or pull requests

2 participants