Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] --code-size: 100%; breaks some plugins #44

Closed
6 of 11 tasks
KiwiFlavorBepis opened this issue Oct 31, 2024 · 2 comments
Closed
6 of 11 tasks

[BUG] --code-size: 100%; breaks some plugins #44

KiwiFlavorBepis opened this issue Oct 31, 2024 · 2 comments
Assignees
@LEFD
Labels
bug Something isn't working

Comments

@KiwiFlavorBepis
Copy link

Describe the Bug
The --code-size CSS variable uses a percentage:

  • In the default Obsidian theme, the --code-size variable is set to --font-smaller which has a value of 0.875em.
  • Plugins expect the --code-size variable to be in terms of em.
  • In Royal Velvet, the --code-size variable is set to 100%.

Potential Fix
Replace --code-size: 100%; with --code-size: 1em;. The effect is the same.

In which mode does the bug occur?

  • Reading/Preview Mode
  • Source Mode
  • Live Preview

Which editor are you using?

  • Legacy Editor
  • New Editor

Which version of Obsidian are you using?

  • Public Release (Desktop)
  • Public Release (Mobile)
  • Insider Release (Desktop)
  • Insider Release (Mobile)

Checklist

  • I have updated to the latest version of the theme (Obsidian Settings → Appearance → Themes - Manage → Update).
  • I made sure that the issue is related to this theme, by checking that the issue does not occur with other themes or the default theme.
@KiwiFlavorBepis KiwiFlavorBepis added the bug Something isn't working label Oct 31, 2024
@LEFD
Copy link
Collaborator

LEFD commented Oct 31, 2024

thanks for the bug report! i'll look into it, as soon as I can.

@LEFD LEFD self-assigned this Oct 31, 2024
@KiwiFlavorBepis
Copy link
Author

Just made a pull request #45 with the change. Its only 1 line.

@LEFD LEFD closed this as completed Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LEFD LEFD

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LEFD @KiwiFlavorBepis