Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Episode 5: Specify the encoding when reading in JSON file #114

Open
milanmlft opened this issue Jul 3, 2024 · 2 comments
Open

Episode 5: Specify the encoding when reading in JSON file #114

milanmlft opened this issue Jul 3, 2024 · 2 comments
Assignees

Comments

@milanmlft
Copy link

milanmlft commented Jul 3, 2024

In episode 5, we're reading in the eva-data.json file. However, some participants got a UnicodeDecodeError because of the unicode characters present in the data.

Specifying encoding="utf8" when opening the file might help, although it might be worth figuring out why only some people got this error.

@SJaffa
Copy link
Contributor

SJaffa commented Aug 12, 2024

We need to find a way to recreate the error. It was no a Windows machine I think but not all Windows users got this error?

@anenadic
Copy link
Collaborator

Indeed not everyone experienced this - but perhaps this machine was not using UTF-8 as the default encoding. Think we could either make this an improvent and a teaching point or just fix this in the started code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants