Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use consistent code style #1

Open
cartoonist opened this issue Dec 19, 2016 · 1 comment
Open

Use consistent code style #1

cartoonist opened this issue Dec 19, 2016 · 1 comment
Assignees
@cartoonist
Labels
enhancement

Comments

@cartoonist
Copy link
Owner

The code style is not consistent throughout the project. Most notable inconsistencies are:

  • variable names and naming convention
  • in some cases, type should be manifest (avoid using auto keyword in those cases)
  • int* x, int *x, int * x or int*x? choose one!
  • multi-line indentation
  • function definition style and indentation
  • spacing (e.g. < class TYPE > or <class TYPE>; func(1) or func (1))
  • aligning variable names is necessary?
  • one-line function bodies style
@cartoonist cartoonist self-assigned this Dec 19, 2016
@tobiasmarschall
Copy link
Collaborator

Please don't spend time on this before we have results / a paper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cartoonist cartoonist

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tobiasmarschall @cartoonist