Add membership resource (#6)

Author: PChambino

README.md

@@ -63,11 +63,12 @@ then create an `.env` file with:
 
     TF_ACC=on
     HIREFIRE_API_KEY=your-key
-
-If testing the user data source also append this to the `.env` file:
-
+    # The following variables are optional.
+    # For user data source:
     HIREFIRE_TEST_USER_ID=user-id
     HIREFIRE_TEST_USER_EMAIL=user-email
+    # For membership resource:
+    HIREFIRE_TEST_MEMBERSHIP_USER_ID=another-user-id
 
 and run with:
 

client/client.go

@@ -17,6 +17,7 @@ type Client struct {
 	TimeRange    *TimeRangeResource
 	Recipient    *RecipientResource
 	User         *UserResource
+	Membership   *MembershipResource
 }
 
 const DefaultURL = "https://api.hirefire.io/"
@@ -40,6 +41,7 @@ func New(apiKey string) *Client {
 	client.TimeRange = &TimeRangeResource{client: client}
 	client.Recipient = &RecipientResource{client: client}
 	client.User = &UserResource{client: client}
+	client.Membership = &MembershipResource{client: client}
 
 	return client
 }

client/membership.go

@@ -0,0 +1,39 @@
+package client
+
+type MembershipResource struct {
+	client *Client
+}
+
+type Membership struct {
+	Id             string `json:"id"`
+	OrganizationId string `json:"organization_id"`
+	UserId         string `json:"user_id"`
+	Owner          bool   `json:"owner"`
+}
+
+type wrappedMembership struct {
+	Membership Membership `json:"membership"`
+}
+
+func (r *MembershipResource) Get(id string) (*Membership, error) {
+	wrapped := &wrappedMembership{}
+	err := r.client.getResource("memberships", id, wrapped)
+	return &wrapped.Membership, err
+}
+
+func (r *MembershipResource) Create(create Membership) (*Membership, error) {
+	wrapped := &wrappedMembership{Membership: create}
+	err := r.client.createResource("memberships", wrapped)
+	return &wrapped.Membership, err
+}
+
+func (r *MembershipResource) Update(update Membership) (*Membership, error) {
+	wrapped := &wrappedMembership{Membership: update}
+	err := r.client.updateResource("memberships", update.Id, wrapped)
+	return &wrapped.Membership, err
+}
+
+func (r *MembershipResource) Delete(id string) error {
+	err := r.client.deleteResource("memberships", id)
+	return err
+}

client/membership_test.go

@@ -0,0 +1,37 @@
+package client
+
+import (
+	"github.com/carwow/terraform-provider-hirefire/testing/assert"
+	"net/http"
+	"net/http/httptest"
+	"testing"
+)
+
+func TestGetMembership(t *testing.T) {
+	server := httptest.NewServer(http.HandlerFunc(func(rw http.ResponseWriter, req *http.Request) {
+		assert.Equals(t, req.URL.String(), "/memberships/ID-123")
+		rw.Write([]byte(`{
+			"membership": {
+				"id":              "ID-123",
+				"organization_id": "ID-999",
+				"user_id":         "ID-888",
+				"owner":           true
+			}
+		}`))
+	}))
+	defer server.Close()
+
+	client := New("secret")
+	client.URL = server.URL + "/"
+
+	membership, err := client.Membership.Get("ID-123")
+	assert.Ok(t, err)
+
+	expected := &Membership{
+		Id:             "ID-123",
+		OrganizationId: "ID-999",
+		UserId:         "ID-888",
+		Owner:          true,
+	}
+	assert.Equals(t, expected, membership)
+}

provider/provider.go

@@ -5,6 +5,7 @@ import (
 	"github.com/carwow/terraform-provider-hirefire/resources/account"
 	"github.com/carwow/terraform-provider-hirefire/resources/application"
 	"github.com/carwow/terraform-provider-hirefire/resources/manager"
+	"github.com/carwow/terraform-provider-hirefire/resources/membership"
 	"github.com/carwow/terraform-provider-hirefire/resources/organization"
 	"github.com/carwow/terraform-provider-hirefire/resources/recipient"
 	"github.com/carwow/terraform-provider-hirefire/resources/time_range"
@@ -29,6 +30,7 @@ func Provider() *schema.Provider {
 			"hirefire_manager":      manager.Resource(),
 			"hirefire_time_range":   time_range.Resource(),
 			"hirefire_recipient":    recipient.Resource(),
+			"hirefire_membership":   membership.Resource(),
 		},
 
 		DataSourcesMap: map[string]*schema.Resource{

resources/account/resource.go

@@ -57,18 +57,6 @@ func read(d *schema.ResourceData, m interface{}) error {
 	return nil
 }
 
-func update(d *schema.ResourceData, m interface{}) error {
-	d.Partial(true)
-
-	_, err := config.Client(m).Account.Update(getAttributes(d))
-	if err != nil {
-		return err
-	}
-
-	d.Partial(false)
-	return nil
-}
-
 func delete(d *schema.ResourceData, m interface{}) error {
 	err := config.Client(m).Account.Delete(d.Id())
 	return err

resources/membership/resource.go

@@ -0,0 +1,99 @@
+package membership
+
+import (
+	"github.com/carwow/terraform-provider-hirefire/client"
+	"github.com/carwow/terraform-provider-hirefire/config"
+	"github.com/hashicorp/terraform-plugin-sdk/helper/schema"
+)
+
+func Resource() *schema.Resource {
+	return &schema.Resource{
+		Create: create,
+		Read:   read,
+		Update: update,
+		Delete: delete,
+
+		Importer: &schema.ResourceImporter{
+			State: importer,
+		},
+
+		Schema: map[string]*schema.Schema{
+			"organization_id": &schema.Schema{
+				Type:     schema.TypeString,
+				Required: true,
+				ForceNew: true,
+			},
+			"user_id": &schema.Schema{
+				Type:     schema.TypeString,
+				Required: true,
+				ForceNew: true,
+			},
+			"owner": &schema.Schema{
+				Type:     schema.TypeBool,
+				Optional: true,
+			},
+		},
+	}
+}
+
+func setAttributes(d *schema.ResourceData, mem *client.Membership) {
+	d.Set("organization_id", mem.OrganizationId)
+	d.Set("user_id", mem.UserId)
+	d.Set("owner", mem.Owner)
+}
+
+func getAttributes(d *schema.ResourceData) client.Membership {
+	return client.Membership{
+		Id:             d.Id(),
+		OrganizationId: d.Get("organization_id").(string),
+		UserId:         d.Get("user_id").(string),
+		Owner:          d.Get("owner").(bool),
+	}
+}
+
+func create(d *schema.ResourceData, m interface{}) error {
+	mem, err := config.Client(m).Membership.Create(getAttributes(d))
+	if err != nil {
+		return err
+	}
+
+	d.SetId(mem.Id)
+	setAttributes(d, mem)
+	return nil
+}
+
+func read(d *schema.ResourceData, m interface{}) error {
+	mem, err := config.Client(m).Membership.Get(d.Id())
+	if err != nil {
+		return err
+	}
+
+	setAttributes(d, mem)
+	return nil
+}
+
+func update(d *schema.ResourceData, m interface{}) error {
+	d.Partial(true)
+
+	_, err := config.Client(m).Membership.Update(getAttributes(d))
+	if err != nil {
+		return err
+	}
+
+	d.Partial(false)
+	return nil
+}
+
+func delete(d *schema.ResourceData, m interface{}) error {
+	err := config.Client(m).Membership.Delete(d.Id())
+	return err
+}
+
+func importer(d *schema.ResourceData, m interface{}) ([]*schema.ResourceData, error) {
+	err := read(d, m)
+	if err != nil {
+		return nil, err
+	}
+
+	return []*schema.ResourceData{d}, nil
+}

resources/membership/resource_test.go

@@ -0,0 +1,118 @@
+package membership_test
+
+import (
+	"fmt"
+	"os"
+	"strconv"
+	"testing"
+
+	"github.com/carwow/terraform-provider-hirefire/client"
+	"github.com/carwow/terraform-provider-hirefire/testing/helper"
+	"github.com/hashicorp/terraform-plugin-sdk/helper/resource"
+	"github.com/hashicorp/terraform-plugin-sdk/terraform"
+)
+
+const resourceName = "hirefire_membership.foobar"
+
+func TestAccMembership(t *testing.T) {
+	orgName := fmt.Sprintf("test-%s", helper.RandString(10))
+	mem := &client.Membership{
+		UserId: os.Getenv("HIREFIRE_TEST_MEMBERSHIP_USER_ID"),
+	}
+
+	if mem.UserId == "" {
+		t.Skip("Membership resource test skipped unless env " +
+			"'HIREFIRE_TEST_MEMBERSHIP_USER_ID' is set")
+	}
+
+	resource.Test(t, resource.TestCase{
+		PreCheck:     helper.PreCheck(t),
+		Providers:    helper.Providers(),
+		CheckDestroy: checkDestroy,
+		Steps: []resource.TestStep{
+			{
+				Config: func(orgName string, mem *client.Membership) string {
+					*mem = client.Membership{
+						UserId: mem.UserId,
+						Owner:  helper.RandBool(),
+					}
+					return config(orgName, mem)
+				}(orgName, mem),
+				Check: checks(*mem),
+			},
+			{
+				Config: func(orgName string, mem *client.Membership) string {
+					*mem = client.Membership{
+						UserId: mem.UserId,
+						Owner:  helper.RandBool(),
+					}
+					return config(orgName, mem)
+				}(orgName, mem),
+				Check: checks(*mem),
+			},
+			{
+				ResourceName:      resourceName,
+				ImportState:       true,
+				ImportStateVerify: true,
+			},
+		},
+	})
+}
+
+func config(orgName string, mem *client.Membership) string {
+	return fmt.Sprintf(`
+		resource "hirefire_organization" "foobar" {
+			name = "%s"
+			time_zone = "UTC"
+		}
+
+		resource "hirefire_membership" "foobar" {
+			organization_id = hirefire_organization.foobar.id
+			user_id         = "%s"
+			owner           = %t
+		}`, orgName, mem.UserId, mem.Owner)
+}
+
+func checks(mem client.Membership) resource.TestCheckFunc {
+	return resource.ComposeAggregateTestCheckFunc(
+		checkAttributes(mem),
+		checkExists(mem),
+	)
+}
+
+func checkAttributes(mem client.Membership) resource.TestCheckFunc {
+	return helper.CheckResourceAttributes(resourceName, map[string]string{
+		"owner": strconv.FormatBool(mem.Owner),
+	})
+}
+
+func checkExists(mem client.Membership) resource.TestCheckFunc {
+	return func(state *terraform.State) error {
+		id, err := helper.GetResourceID(state, resourceName)
+		if err != nil {
+			return err
+		}
+
+		actualMembership, err := helper.Client().Membership.Get(id)
+		if err != nil {
+			return err
+		}
+
+		mem.Id = actualMembership.Id
+		mem.OrganizationId = actualMembership.OrganizationId
+		return helper.Equals(mem, *actualMembership)
+	}
+}
+
+func checkDestroy(state *terraform.State) error {
+	id, err := helper.GetResourceID(state, resourceName)
+	if err != nil {
+		return err
+	}
+
+	_, err = helper.Client().Membership.Get(id)
+	if err == nil {
+		return fmt.Errorf("Not destroyed: %s", resourceName)
+	}
+	return nil
+}