Fix bug in frame triggering for BroadcastFrameClock contexts #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds like the same behavior I was seeing here. |
|
Maybe. These changes don't break In any event, I think that the expectation in the test case is reasonable; it would be really confusing in prod if that scenario failed to produce an additional model. |
|
Pulling until I work out the issues with this PR. It doesn't address my issue as I thought it did, so: needs more work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recomposer.runRecomposeAndApplyChangesalways waits for a frame tick before recomposing a child composition. As a result, the call toSnapshot.sendApplyNotifications()isn't achieving the desired outcome in the existing code: under test, writes to snapshot state will fail to produce an additional output.snapshotUpdatesTickEnclosingClockillustrates the issue.To get the test to pass, though, the call to
composition.setContenthas to be moved to the beginning oflaunchMolecule. This is probably due to a race withinRecomposer.Also fixes #45.