Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow operators to burn the nft #243

Closed
imsk17 opened this issue Jul 7, 2023 · 7 comments · Fixed by #250
Closed

allow operators to burn the nft #243

imsk17 opened this issue Jul 7, 2023 · 7 comments · Fixed by #250
Assignees

Comments

@imsk17
Copy link

imsk17 commented Jul 7, 2023

The burn endpoint simply does not care about approval as of right now. but, the operator should be allowed to burn the nft. IE in both ERC721 and ERC1155 contracts, an operator can burn the token

@RitaMAllenCA
Copy link

@gRoussac @zoltan @EdHastingsCasperLabs please comment so we can respond. @RBYGLLS

@imsk17
Copy link
Author

imsk17 commented Jul 13, 2023

I would like to work on this one if possible.

@gRoussac
Copy link
Contributor

gRoussac commented Jul 13, 2023

Hi all, @imsk17 thanks for raising this issue.

The ercs are not very specific on that, I guess it depends of the implementation of the interface but it does not seem an hard requirement tho.
ERC-721-OpenZeppelin-Docs (1)
ERC-1155-OpenZeppelin-Docs

I think the decision was taken to only allow an owner to burn its token in ceps 18/78/85. I believe this should remain default case but could be a modality in cep-78 and 85 (allow operator burn). It could be also a "modality" in form of a boolean on install of cep-18 probably. I would recommend to do the three ceps alike and at the same time + corresponding tests in each.

@imsk17
Copy link
Author

imsk17 commented Jul 13, 2023

so, should I implement this modality on all three standards?

@zoltan
Copy link

zoltan commented Jul 13, 2023

you might want to put the right person there, as I'm the wrong @zoltan :)

@gRoussac
Copy link
Contributor

@deuszex FYI

@gRoussac gRoussac linked a pull request Sep 25, 2023 that will close this issue
@gRoussac
Copy link
Contributor

gRoussac commented Oct 3, 2023

@imsk17 thanks for your report and kind proposition, we needed to treat a previous related issue #249 on mint/transfers before this operator burn mode. I opened a PR #250 to add it on CEP-78 for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants