Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Conflict in configure_backend function when using ndx-events 0.3.0 and other extesion #908

Open
2 tasks done
alessandratrapani opened this issue Jun 13, 2024 · 5 comments · May be fixed by #998
Open
2 tasks done

[Bug]: Conflict in configure_backend function when using ndx-events 0.3.0 and other extesion #908

alessandratrapani opened this issue Jun 13, 2024 · 5 comments · May be fixed by #998
Labels
bug

Comments

@alessandratrapani
Copy link
Contributor

alessandratrapani commented Jun 13, 2024 •
edited
Loading

What happened?

Conflict in configure_backend function when using ndx-events 0.3.0 and other extension, e.g ndx-facemap-motion.
The neurodata objects in ndx-facemap-motion are not either Data or TimeSeries, thus it will enter the following if condition:

neuroconv/src/neuroconv/tools/nwb_helpers/_configure_backend.py

Lines 56 to 59 in 5a65e74

elif is_ndx_events_installed and isinstance(neurodata_object, ndx_events.Events):
neurodata_object.set_data_io(
dataset_name=dataset_name, data_io_class=data_io_class, data_io_kwargs=data_io_kwargs
)

However, when using ndx-events 0.3.0 this will cause an error since ndx_events.Events it's compatible only with ndx-events 0.2.0

trace back error

Screenshot from 2024-06-13 10-45-32

Operating System

Linux

Python Executable

Conda

Python Version

3.8

Package Versions

No response

Code of Conduct
@pauladkisson
Copy link
Member

Could probably add a check for ndx_events_is_version_0_2_0 and then only check ndx_events.Events if it's the right version?

@alessandratrapani
Copy link
Contributor Author

add check for ndx_event version

@CodyCBakerPhD
Copy link
Member

Is ndx-events==0.3.0 released?

@alessandratrapani alessandratrapani linked a pull request Aug 12, 2024 that will close this issue
Open
@alessandratrapani alessandratrapani linked a pull request Aug 12, 2024 that will close this issue
Fix #908 #998
Open
@h-mayorquin
Copy link
Collaborator

It does not seem it is:

https://pypi.org/project/ndx-events/#history

@h-mayorquin
Copy link
Collaborator

Relevant, check the discussion here:
catalystneuro/schneider-lab-to-nwb#11 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #908 catalystneuro/neuroconv
4 participants
@h-mayorquin @pauladkisson @CodyCBakerPhD @alessandratrapani