Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change fn/ctrl/alt/super order #59

Open
aruhier opened this issue Feb 21, 2018 · 11 comments
Open

Change fn/ctrl/alt/super order #59

aruhier opened this issue Feb 21, 2018 · 11 comments

Comments

@aruhier
Copy link

aruhier commented Feb 21, 2018

Hi,
This patched hid-apple module has some options to change the order of the fn, ctrl, alt and super keys, to act like a PC keyboard. Is this possible for you to implement it on this spi driver?

Thanks a lot!
@roadrunner2
Copy link
Contributor

Hmm, generally I don't think such key remappings belong in the drivers - that's what the settings in Gnome, KDE, xkb, keymaps, etc are for (without then needing to duplicate the options for every single keyboard driver).

Having said that, the FN key is special, since that's handled in the driver directly, so I could see a case for a config option to allow just that key to be swapped with any of the other meta keys. @cb22 any thoughts/opinions?

@omnibrain
Copy link

I would love the option to remap the FN key! My plan was to remap all the media keys on the function keys but configuring the FN key directly on the driver would be much more elegant

roadrunner2 referenced this issue in roadrunner2/macbook12-spi-driver May 20, 2018
@roadrunner2
applespi: Add option to swap fn key with a modifier key.
c6fa6a3 
Only the fn key can be swapped, because the key is handled specially in
the driver - for all other key remappings use the console and desktop
key mapping mechanisms.

This closes #59.
@roadrunner2
Copy link
Contributor

I've pushed a simple patch over on my repo that adds a new fnremap module parameter: it allows you swap the fn key with any of the 7 modifier keys (see the output from modinfo applespi.ko or the source code for valid values). See if this works for you.

P.S. when/if you do try it out, could you also report the output from dmesg | grep "applespi: info" over at #64 (see also Dunedan/mbp-2016-linux#61). TIA.

@aruhier
Copy link
Author

aruhier commented May 21, 2018

@roadrunner2 thanks a lot, I'll test it tomorrow ;)

roadrunner2 referenced this issue in roadrunner2/macbook12-spi-driver Aug 1, 2018
@roadrunner2
applespi: Add option to swap fn key with a modifier key.
38846f3 
Only the fn key can be swapped, because the key is handled specially in
the driver - for all other key remappings use the console and desktop
key mapping mechanisms.

This closes #59.
@roadrunner2
Copy link
Contributor

Anybody been able to test this yet?

@aruhier
Copy link
Author

aruhier commented Aug 10, 2018

I tested it in June, but it wasn't working for me on a mbp 14.3. I'm sorry, I swapped this laptop with a thinkpad, so I cannot help you to debug more :(

@roadrunner2
Copy link
Contributor

Thanks for looking at this. A bit unfortunate that you didn't let me know back then so we could've debugged it. Oh well.

Anybody else try this? @omnibrain or @arno01?

roadrunner2 referenced this issue in roadrunner2/macbook12-spi-driver Sep 3, 2018
@roadrunner2
applespi: Add option to swap fn key with a modifier key.
442f7a2 
Only the fn key can be swapped, because the key is handled specially in
the driver - for all other key remappings use the console and desktop
key mapping mechanisms.

This closes #59.
@roadrunner2
Copy link
Contributor

@Dunedan, do you perchance have a couple spare cycles to test this? Sorry to bug you with this, but I'd like to include this in my next pull request and when upstreaming the driver, and for that I need at least one person to confirm it works.

roadrunner2 referenced this issue in roadrunner2/macbook12-spi-driver Sep 11, 2018
@roadrunner2
applespi: Add option to swap fn key with a modifier key.
6820c3b 
Only the fn key can be swapped, because the key is handled specially in
the driver - for all other key remappings use the console and desktop
key mapping mechanisms.

This closes #59.
@Dunedan
Copy link
Contributor

Dunedan commented Sep 13, 2018

Sorry that took a while. I did a quick test and it seems to work fine. 👍
As I'm not going to use this feature, I can't tell anything about possible side effects when using it a while.

@arno01
Copy link

arno01 commented Sep 17, 2018 •
edited
Loading

@roadrunner2 oh, I am not sure how did I miss that feature, but this is something I really needed.
I've just switched to use it modprobe applespi fnremap=1 and it is working fine, much thanks! :-)

To add in my case I am using 442f7a2 which is same as 6820c3b

roadrunner2 referenced this issue in roadrunner2/macbook12-spi-driver Sep 18, 2018
@roadrunner2
applespi: Add option to swap fn key with a modifier key.
f4dc43c 
Only the fn key can be swapped, because the key is handled specially in
the driver - for all other key remappings use the console and desktop
key mapping mechanisms.

This closes #59.
@roadrunner2
Copy link
Contributor

Thanks to both of you for testing this! Now I have a little more confidence in submitting it upstream 😄

@Dunedan Dunedan mentioned this issue Sep 20, 2018
Closed
roadrunner2 referenced this issue in roadrunner2/macbook12-spi-driver Sep 25, 2018
@roadrunner2
applespi: Add option to swap fn key with a modifier key.
458e20c 
Only the fn key can be swapped, because the key is handled specially in
the driver - for all other key remappings use the console and desktop
key mapping mechanisms.

This closes #59.
roadrunner2 referenced this issue in roadrunner2/macbook12-spi-driver Oct 29, 2018
@roadrunner2
applespi: Add option to swap fn key with a modifier key.
8aebf48 
Only the fn key can be swapped, because the key is handled specially in
the driver - for all other key remappings use the console and desktop
key mapping mechanisms.

This closes #59.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@roadrunner2 @aruhier @Dunedan @omnibrain @arno01