Update default.vw_pin_sale with a holistic outlier_reason field #966
Description
This issue spawned from a discussion comment in this issue .
Copying the comment below for the record:
Hmm, this is a great point. Building on the new is_outlier data model, I wonder if we could use a new outlier_reason field that can similarly coalesce model outlier reasons with analyst override outlier reasons? I'm imagining an array of strings that includes all sv_outlier_reason{N} values, plus any fieldnames from sale.flag_override that led to a sale being marked as an outlier. Does that seem reasonable to you? I'm happy to chat this out in person if it'd be easier, since there are some tricky follow-up design decisions (e.g. do we include sv_outlier_reason{N} values even when is_outlier is false). Regardless, I think you're right that we should tackle this in a separate issue -- if we pursue this direction, we'll likely want a data-architecture PR to define the field, and then a PR on each of model-res-avm and model-condo-avm to switch up the reporting to use this new combined fields for outlier reasons.