Missing Return Statement in PostgreSQL Driver #122
Description
Bug Report
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | needs verification |
| Licence | Apache-2.0 |
Missing Return Statement in PostgreSQL Driver
File: /src/Ting/Driver/Pgsql/Driver.php
Method: reconnect()
Line: ~540
Severity: MEDIUM
Issue: The reconnect() method in the PostgreSQL driver does not return true on successful reconnection, unlike the MySQL driver implementation. This inconsistency could cause issues for code that relies on the return value.
Current behavior: Method returns null on success, false on failure
Expected behavior: Method should return true on success, false on failure (consistent with MySQL driver)
@vgreb @xavierleune It’s up to you to decide: either remove the return statement, or add a break/exit inside the conditional as in the exception block in the PHP code, or drop the method’s return type declaration altogether.