Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Data Table from overflowing its container #1

Open
jeanpaulrsoucy opened this issue Feb 5, 2022 · 1 comment
Open

Prevent Data Table from overflowing its container #1

jeanpaulrsoucy opened this issue Feb 5, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@jeanpaulrsoucy
Copy link
Member

The Data Table can overflow its container when selecting a dataset with a very long name, e.g., bc/7-day-and-cumulative-cases-by-hsda.

@jeanpaulrsoucy jeanpaulrsoucy added the bug Something isn't working label Aug 17, 2022
jeanpaulrsoucy added a commit that referenced this issue Aug 18, 2022
- Add CSS word-break: break-word in file table
- Set fixed column widths (prevent date column from wrapping unnecessarily)
jeanpaulrsoucy added a commit that referenced this issue Dec 21, 2022
- Give page title in navbar class "navbar-text" and add padding
- Change classes of columns for left and right boxes to ensure correct sizing on mobile (closes #18)
- Change active indicator from "True" / "False" to check mark / cross mark
- Add row and column to datasets table (note that this does not solve #1)
@jeanpaulrsoucy
Copy link
Member Author

jeanpaulrsoucy commented Dec 23, 2022

Adding table-layout: fixed to the CSS of the table seems to fix the overflow issue, but makes both the table and any expanded child rows very ugly and squashed. Perhaps allowing horizontal scrolling for the table is acceptable. In this case, should modify the Bootstrap class of the containing div to accommodate this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant