Skip to content

Test selfie_hellovar.sh fails if the current timestamp changes while test is executed #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
enter-github-username opened this issue May 1, 2023 · 0 comments

Comments

@enter-github-username
Copy link

While running benchmarks on selFIe, I found that the test selfie_hellovar.sh is flaky, i.e. it fails sometimes.

The test selfie_hellovar.sh saves the current timestamp into the SELFIE_TEST variable. After the code under test finishes, it searches for the timestamp inside the error output of the code under test.

However, and I believe this causes the flaky behaivior, if the timestamp changes between the test itself and the code under test reading the current timestamp (e.g. by the test taking longer than a second or the test being started close to the "end of a second"), the grep call fails, causing the test to fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant