Merge pull request #13 from cedricduffournet/change_civility_association

Change civility association to prevent deleting user in cascade

Author: cedricduffournet

app/src/Controller/CivilityController.php

@@ -5,6 +5,7 @@
 use App\Entity\Civility;
 use App\Form\CivilityType;
 use App\Service\CivilityServiceInterface;
+use Doctrine\DBAL\Exception\ForeignKeyConstraintViolationException;
 use FOS\RestBundle\Controller\AbstractFOSRestController;
 use FOS\RestBundle\Controller\Annotations as Rest;
 use FOS\RestBundle\View\View;
@@ -16,6 +17,7 @@
 use Symfony\Component\Form\Form;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
+use Symfony\Component\HttpKernel\Exception\BadRequestHttpException;
 
 /**
  * Controller used to managed Civility resource.
@@ -204,7 +206,11 @@ public function putCivility(Request $request, Civility $civility): View
      */
     public function deleteCivility(Request $request, Civility $civility): View
     {
-        $this->civilityService->deleteCivility($civility);
+        try {
+            $this->civilityService->deleteCivility($civility);
+        } catch (ForeignKeyConstraintViolationException $e) {
+            throw new BadRequestHttpException('You can not delete this entity');
+        }
 
         return $this->view([], Response::HTTP_NO_CONTENT);
     }

app/src/Entity/User.php

@@ -83,7 +83,7 @@ class User extends BaseUser
      * @var Civility
      *
      * @ORM\ManyToOne(targetEntity="Civility")
-     * @ORM\JoinColumn(name="civility_id", referencedColumnName="id",  onDelete="CASCADE")
+     * @ORM\JoinColumn(nullable=false)
      * @Groups({"user_info"})
      * @Assert\NotBlank()
      */

app/src/Migrations/Version20190707102406.php

@@ -0,0 +1,39 @@
+<?php
+
+declare(strict_types=1);
+
+namespace DoctrineMigrations;
+
+use Doctrine\DBAL\Schema\Schema;
+use Doctrine\Migrations\AbstractMigration;
+
+/**
+ * Auto-generated Migration: Please modify to your needs!
+ */
+final class Version20190707102406 extends AbstractMigration
+{
+    public function getDescription(): string
+    {
+        return '';
+    }
+
+    public function up(Schema $schema): void
+    {
+        // this up() migration is auto-generated, please modify it to your needs
+        $this->abortIf('mysql' !== $this->connection->getDatabasePlatform()->getName(), 'Migration can only be executed safely on \'mysql\'.');
+
+        $this->addSql('ALTER TABLE fos_user DROP FOREIGN KEY FK_957A647923D6A298');
+        $this->addSql('ALTER TABLE fos_user CHANGE civility_id civility_id INT NOT NULL');
+        $this->addSql('ALTER TABLE fos_user ADD CONSTRAINT FK_957A647923D6A298 FOREIGN KEY (civility_id) REFERENCES civility (id)');
+    }
+
+    public function down(Schema $schema): void
+    {
+        // this down() migration is auto-generated, please modify it to your needs
+        $this->abortIf('mysql' !== $this->connection->getDatabasePlatform()->getName(), 'Migration can only be executed safely on \'mysql\'.');
+
+        $this->addSql('ALTER TABLE fos_user DROP FOREIGN KEY FK_957A647923D6A298');
+        $this->addSql('ALTER TABLE fos_user CHANGE civility_id civility_id INT DEFAULT NULL');
+        $this->addSql('ALTER TABLE fos_user ADD CONSTRAINT FK_957A647923D6A298 FOREIGN KEY (civility_id) REFERENCES civility (id) ON DELETE CASCADE');
+    }
+}