Fix zip loading #1005

samylan · 2018-12-31T13:25:58Z

test-zip-loading.zip
This patch resolve some problems I encountered while trying to load zip files from a server :

Missing return statement that were preventing promise to works when zip file where loaded from a server.
After loading a Zip file, the fileMap was not updated. osgDB would then try to load files that were in the zip directly from the server.
Since the fileMap is a real Map object, the [] operator wouldn't work to check if file were existing.

Here is the error I would get when loading a zip file without the return statements :

Unhandled rejection readNodeURL/<@webpack:///./sources/osgPlugins/ReaderWriterZIP.js?:49:13
r@http://localhost:9000/node_modules/bluebird/js/browser/bluebird.min.js:31:9667
[22]</e.exports/i.prototype._settlePromiseFromHandler@http://localhost:9000/node_modules/bluebird/js/browser/bluebird.min.js:30:14825
[22]</e.exports/i.prototype._settlePromise@http://localhost:9000/node_modules/bluebird/js/browser/bluebird.min.js:30:15628
[22]</e.exports/i.prototype._settlePromise0@http://localhost:9000/node_modules/bluebird/js/browser/bluebird.min.js:30:16329
[22]</e.exports/i.prototype._settlePromises@http://localhost:9000/node_modules/bluebird/js/browser/bluebird.min.js:30:17684
c@http://localhost:9000/node_modules/bluebird/js/browser/bluebird.min.js:29:1555
a@http://localhost:9000/node_modules/bluebird/js/browser/bluebird.min.js:29:1496
[2]</r.prototype._drainQueues@http://localhost:9000/node_modules/bluebird/js/browser/bluebird.min.js:29:3106
r/this.drainQueues@http://localhost:9000/node_modules/bluebird/js/browser/bluebird.min.js:29:1236

Here is a test case to be used in the examples folder :
test-zip-loading.zip

…ted.

…t try to load them from the server.

Samy Lange added 4 commits September 21, 2018 22:43

Use Map "has" method so that an undefined filesMap is correctly detec…

773de17

…ted.

Register unzipped files in readerWriterZIP so that readNodeUrl doesn'…

52c0bd8

…t try to load them from the server.

Return a promise when needed. It fixes the loading of some zip files.

47f02e7

Fix code style.

72f9c13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix zip loading #1005

Fix zip loading #1005

samylan commented Dec 31, 2018 •

edited

Loading

Fix zip loading #1005

Are you sure you want to change the base?

Fix zip loading #1005

Conversation

samylan commented Dec 31, 2018 • edited Loading

samylan commented Dec 31, 2018 •

edited

Loading