Skip to content

PR #2198 and PR #2207 Fixed #2219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
+7 −6
Draft

PR #2198 and PR #2207 Fixed #2219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8a9fc33
unit test fixed
MehrazRumman Jan 6, 2025
59dfc96
github workflows updated
MehrazRumman Jan 8, 2025
e374faf
pypy 3.10 excluded from github workflow
MehrazRumman Jan 8, 2025
bf67ea4
pypy3.10 included
MehrazRumman Jan 8, 2025
ea52094
Merge branch 'main' into main
auvipy Feb 5, 2025
92ac878
Merge branch 'main' into main
auvipy May 8, 2025
cfe4560
Merge branch 'main' into main
auvipy Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/python-package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,13 +92,13 @@ jobs:
include:
- python-version: pypy3.10
toxenv: 'py-amqp'
Copy link
Member

@auvipy auvipy Jan 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this part have to be removed? Can you explain please?

Copy link
Contributor Author

@MehrazRumman MehrazRumman Jan 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes , I think pypy3.10 is required here for make certain workloads faster. I will undo the change .

experimental: true
experimental: false
- python-version: pypy3.10
toxenv: 'py-redis'
experimental: true
experimental: false
- python-version: pypy3.10
toxenv: 'py-mongodb'
experimental: true
experimental: false
# - python-version: pypy3.10
# toxenv: 'py-kafka'
# experimental: true
Expand Down
2 changes: 1 addition & 1 deletion requirements/extras/gcpubsub.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
google-cloud-pubsub>=2.18.4
google-cloud-monitoring>=2.16.0
grpcio==1.67.0
grpcio==1.68.1
protobuf==5.29.5
5 changes: 3 additions & 2 deletions t/unit/transport/test_gcpubsub.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,12 +285,13 @@ def test_create_subscription(self, channel):
channel.subscriber.create_subscription.assert_called_once()

def test_create_subscription_protobuf_compat(self):
from datetime import timedelta
request = {
'name': 'projects/my_project/subscriptions/kombu-1111-2222',
'topic': 'projects/jether-fox/topics/reply.celery.pidbox',
'ack_deadline_seconds': 240,
'expiration_policy': {'ttl': '86400s'},
'message_retention_duration': '86400s',
'expiration_policy': {'ttl': timedelta(seconds=86400)},
'message_retention_duration': timedelta(seconds=86400),
'filter': 'attributes.routing_key="1111-2222"',
}
Subscription(request)
Expand Down