Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark outdated ADRs as superseded #2159

Closed
evan-forbes opened this issue Jul 25, 2023 · 4 comments · Fixed by #3032
Closed

Mark outdated ADRs as superseded #2159

evan-forbes opened this issue Jul 25, 2023 · 4 comments · Fixed by #3032
Assignees
@rootulp
Labels
documentation Improvements or additions to documentation

Comments

@evan-forbes
Copy link
Member

We have a lot of ADRs that have been overwritten or superseded by newer ones, we should mark them superseded and point to the latest iteration of whatever relevant ADR
@evan-forbes evan-forbes added the documentation Improvements or additions to documentation label Jul 25, 2023
@rootulp
Copy link
Collaborator

rootulp commented Jul 25, 2023

ADR-009 is superseded by ADR-013. Which other ADRs are superseded?

@evan-forbes
Copy link
Member Author

parts of ADR001, ADR006, ADR005, ADR004 I believe

@rootulp
Copy link
Collaborator

rootulp commented Jul 25, 2023

Oh yea parts of ADR-006 are superseded by ADR-020

@rootulp
Copy link
Collaborator

rootulp commented Jan 21, 2024

  • I don't think we have another ADR with more info on the current ABCI++ implementation so not sure what to update ADR001 to.
  • ADR006 says it was deprecated.
  • I don't see any QGB ADRs after ADR005 so not sure what to update ADR005 or ADR004 to.

@rootulp rootulp self-assigned this Jan 21, 2024
@rootulp rootulp mentioned this issue Jan 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rootulp rootulp

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: mark outdated ADRs rootulp/celestia-app
2 participants
@rootulp @evan-forbes