diff --git a/service/header/core_listener_test.go b/service/header/core_listener_test.go index 84efa9627e..a20caaf126 100644 --- a/service/header/core_listener_test.go +++ b/service/header/core_listener_test.go @@ -32,19 +32,18 @@ func TestCoreListener(t *testing.T) { fetcher := createCoreFetcher(t) // create CoreListener and start listening - cl := createCoreListener(t, fetcher, ps0) + cl := createCoreListener(ctx, t, fetcher, ps0) err = cl.Start(ctx) require.NoError(t, err) // ensure headers are getting broadcasted to the gossipsub topic for i := 1; i < 6; i++ { - msg, err := sub.Next(context.Background()) + msg, err := sub.Next(ctx) require.NoError(t, err) var resp ExtendedHeader err = resp.UnmarshalBinary(msg.Data) require.NoError(t, err) - require.Equal(t, i, int(resp.Height)) } err = cl.Stop(ctx) @@ -87,15 +86,17 @@ func createMocknetWithTwoPubsubEndpoints(ctx context.Context, t *testing.T) (*pu } func createCoreListener( + ctx context.Context, t *testing.T, fetcher *core.BlockFetcher, ps *pubsub.PubSub, ) *CoreListener { p2pSub := NewP2PSubscriber(ps) - err := p2pSub.Start(context.Background()) + err := p2pSub.Start(ctx) require.NoError(t, err) t.Cleanup(func() { - p2pSub.Stop(context.Background()) //nolint:errcheck + err := p2pSub.Stop(ctx) + require.NoError(t, err) }) return NewCoreListener(p2pSub, fetcher, mdutils.Mock()) diff --git a/service/header/p2p_subscriber.go b/service/header/p2p_subscriber.go index 8ff1185193..1e167985ef 100644 --- a/service/header/p2p_subscriber.go +++ b/service/header/p2p_subscriber.go @@ -40,7 +40,7 @@ func (p *P2PSubscriber) Start(context.Context) (err error) { func (p *P2PSubscriber) Stop(context.Context) error { err := p.pubsub.UnregisterTopicValidator(PubSubTopic) if err != nil { - return err + log.Warnf("unregistering validator: %s", err) } return p.topic.Close()