Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

read discovery params with defaults #271

Closed
caroav opened this issue Oct 19, 2023 · 1 comment · Fixed by #264
Closed

read discovery params with defaults #271

caroav opened this issue Oct 19, 2023 · 1 comment · Fixed by #264
Assignees
@gbregman

Comments

@caroav
Copy link
Collaborator

caroav commented Oct 19, 2023

Use get_with_default() to read discovery params, or else we get an exception if it doesn't exist. The default values should be:

[discovery]
addr = 0.0.0.0
port = 8009
debug = 20
@github-project-automation github-project-automation bot moved this to 🆕 New in NVMe-oF Oct 19, 2023
@gbregman gbregman linked a pull request Oct 19, 2023 that will close this issue
Add CLI that enables NVMe ANA report per volumes and utilizes SPDK ANA-groupIds, ANA states for namespaces and listeners #264
Merged
@gbregman
Copy link
Contributor

Fixed by PR #264

@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NVMe-oF Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gbregman gbregman

Labels
None yet
Projects
NVMe-oF
Archived in project
Milestone
No milestone
2 participants
@caroav @gbregman