Skip to content

Commit bc69fea

Browse files
committed
Fix scrollDown action not working properly when element present but not displayed
1 parent 0b293b4 commit bc69fea

File tree

1 file changed

+2
-7
lines changed

1 file changed

+2
-7
lines changed

source/src/main/java/org/cerberus/core/service/appium/impl/AppiumService.java

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -409,17 +409,12 @@ private boolean scrollDown(AppiumDriver driver, By element, int numberOfScrollDo
409409

410410
do {
411411
boolean isPresent = driver.findElements(element).size() > 0;
412-
if (isPresent) {
413-
Object elmtObj = driver.findElements(element).get(0);
414-
415-
if (elmtObj != null && ((MobileElement) elmtObj).isDisplayed()) {
416-
return true;
417-
}
412+
if (isPresent && driver.findElement(element).isDisplayed()) {
413+
return true;
418414
} else {
419415
scroll(driver, pressX, bottomY, pressX, topY);
420416
}
421417
i++;
422-
423418
} while (i <= numberOfScrollDown);
424419

425420
return false;

0 commit comments

Comments
 (0)