Skip to content

Commit 3aad04d

Browse files
committed
Minor refactorings
1 parent ce4a3bc commit 3aad04d

File tree

2 files changed

+15
-13
lines changed

2 files changed

+15
-13
lines changed
Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,38 +1,38 @@
1-
import { $signal, isASignal } from "../core";
1+
import { $signal, isSignal } from "../core";
22

33
describe("isASignal", () => {
44
test("checks that a value is a signal", () => {
55
const signal = $signal(0);
6-
expect(isASignal(signal)).toBe(true);
6+
expect(isSignal(signal)).toBe(true);
77
});
88

99
test("checks that a computed is a signal", () => {
1010
const signal = $signal(0);
1111
const computed = $signal(() => signal.value);
12-
expect(isASignal(computed)).toBe(true);
12+
expect(isSignal(computed)).toBe(true);
1313
});
1414

1515
test("checks that a value is not a signal", () => {
16-
expect(isASignal(0)).toBe(false);
16+
expect(isSignal(0)).toBe(false);
1717
});
1818

1919
test("checks that a function is not a signal", () => {
20-
expect(isASignal(() => {})).toBe(false);
20+
expect(isSignal(() => {})).toBe(false);
2121
});
2222

2323
test("checks that an object is not a signal", () => {
24-
expect(isASignal({})).toBe(false);
24+
expect(isSignal({})).toBe(false);
2525
});
2626

2727
test("checks that an array is not a signal", () => {
28-
expect(isASignal([])).toBe(false);
28+
expect(isSignal([])).toBe(false);
2929
});
3030

3131
test("checks that undefined is not a signal", () => {
32-
expect(isASignal(undefined)).toBe(false);
32+
expect(isSignal(undefined)).toBe(false);
3333
});
3434

3535
test("checks that null is not a signal", () => {
36-
expect(isASignal(null)).toBe(false);
36+
expect(isSignal(null)).toBe(false);
3737
});
3838
});

src/lwc/signals/core.ts

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -246,6 +246,8 @@ class TrackedState<T> implements TrackableState<T> {
246246
}
247247
}
248248

249+
const SIGNAL_OBJECT_BRAND = Symbol.for("lwc-signals");
250+
249251
/**
250252
* Creates a new signal with the provided value. A signal is a reactive
251253
* primitive that can be used to store and update values. Signals can be
@@ -331,7 +333,7 @@ function $signal<T>(
331333
setter(newValue);
332334
}
333335
},
334-
brand: Symbol.for("lwc-signals"),
336+
brand: SIGNAL_OBJECT_BRAND,
335337
readOnly: {
336338
get value() {
337339
return getter();
@@ -534,8 +536,8 @@ function $resource<ReturnType, Params>(
534536
};
535537
}
536538

537-
function isASignal(anything: unknown): anything is Signal<unknown> {
538-
return !!anything && (anything as Signal<unknown>).brand === Symbol.for("lwc-signals");
539+
function isSignal(anything: unknown): anything is Signal<unknown> {
540+
return !!anything && (anything as Signal<unknown>).brand === SIGNAL_OBJECT_BRAND;
539541
}
540542

541-
export { $signal, $effect, $computed, $resource, isASignal };
543+
export { $signal, $effect, $computed, $resource, isSignal };

0 commit comments

Comments
 (0)