Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cypres Tests on GitHub Actions #246

Closed
wp99cp opened this issue Nov 6, 2023 · 1 comment · Fixed by #233
Closed

Fix Cypres Tests on GitHub Actions #246

wp99cp opened this issue Nov 6, 2023 · 1 comment · Fixed by #233
Assignees
Labels
bug Something isn't working ci

Comments

@wp99cp
Copy link
Member

wp99cp commented Nov 6, 2023

Currently, the Cypress tests fail within the GitHub Actions. If you run Cypress, all tests pass

This is caused by the runner configuration of Github, which has only a limited number of cores. We can reproduce the error locally using Docker Desktop if we constrain the number of CPUs to 2.

During the first export the container awt-swiss-tml-api crashed due to a worker who was killed.
See log:

[2023-11-06 14:49:45 +0000] [7] [WARNING] Worker with pid 8 was terminated due to signal 11

Additionally, I think that the error handling introduced yesterday causes that error to fail the export. If you check older runs, you can observe that such crashes occure there aswell, but they get newer raised to the frontend. Why that‘s the case and why export still worked needs some investigation…

@wp99cp wp99cp added bug Something isn't working ci labels Nov 6, 2023
@wp99cp wp99cp self-assigned this Nov 6, 2023
wp99cp added a commit that referenced this issue Nov 6, 2023
@wp99cp
Copy link
Member Author

wp99cp commented Nov 6, 2023

The above explanation is wrong. I can reproduce the crash with a higher CPU count., if there are many concurrent requests to the TLM server --> see #247 there are two types of crashes

additionally 60f50c6 fixes some issues during the download of the index

@maede97 maede97 linked a pull request Dec 20, 2023 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant