Skip to content
This repository has been archived by the owner on Jun 24, 2020. It is now read-only.

Incorrect countyAPI URL silently fails #317

Open
anselmbradford opened this issue Jan 26, 2015 · 2 comments
Open

Incorrect countyAPI URL silently fails #317

anselmbradford opened this issue Jan 26, 2015 · 2 comments

Comments

@anselmbradford
Copy link
Member

If the rateCheckerAPI value is left out of config/config.json, there is a helpful message:
screen shot 2015-01-26 at 1 48 35 pm

However, if the countyAPI value is left out of config/config.json, the app works till a county is needed at which point the County dropdown is just empty. If the countyAPI URL is absent the app should show the same alert message as when the rateCheckerAPI value is absent.

@mthibos
Copy link
Contributor

mthibos commented Jan 26, 2015

@anselmbradford
This message is actually intended for the user, and appears on our live site as well when the API is down or excessively slow. I think you received it because, without having the API installed, the rate checker cannot call the API.

So, not sure if maybe we need a different kind of warning for developers who are trying to install the code?

@anselmbradford
Copy link
Member Author

@mthibos
If there's ever the scenario that the county API can be down or slow, independent of the mortgage API, this appears like it would be an issue that would appear on the live site for the user.

My 2 cents would be it's fine to show the same (user-intended) message if either API is not available, which will just signal that something is not configured properly. As is, if for some reason the county API is absent or not available the app will work till you get to the County dropdown, which makes it look like a bug, not a config issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants