You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
E.g. gvk::create_image_from_file... and similar functions can be used freely. Is that actually okay? Shouldn't they also be accessible via gvk::context()?
If it can be argued that there's no use in having them defined as context-functions and free functions are fine in terms of the Gears-Vk structure... wouldn't it be better to make them context-functions regardless... just because of consistency reasons alone?!
Consider the following example from the compute_image_processing example application:
mInputImageAndSampler = gvk::context().create_image_sampler(
gvk::context().create_image_view(gvk::create_image_from_file("assets/lion.png", false, false, true, 4, avk::memory_usage::device, avk::image_usage::general_storage_image)), // TODO: We could bind the image as a texture instead of a (readonly) storage image, then we would not need the "storage_image" usage type
gvk::context().create_sampler(avk::filter_mode::bilinear, avk::border_handling_mode::clamp_to_edge)
);
How can it be justified to create the image view via a context-function (gvk::context().create_image_view) and the image itself via a free function (gvk::create_image_from_file)? After all, within gvk::create_image_from_file a context function is called anyways (namely context().create_image).
The text was updated successfully, but these errors were encountered:
E.g.
gvk::create_image_from_file...
and similar functions can be used freely. Is that actually okay? Shouldn't they also be accessible viagvk::context()
?If it can be argued that there's no use in having them defined as context-functions and free functions are fine in terms of the Gears-Vk structure... wouldn't it be better to make them context-functions regardless... just because of consistency reasons alone?!
Consider the following example from the
compute_image_processing
example application:How can it be justified to create the image view via a context-function (
gvk::context().create_image_view
) and the image itself via a free function (gvk::create_image_from_file
)? After all, withingvk::create_image_from_file
a context function is called anyways (namelycontext().create_image
).The text was updated successfully, but these errors were encountered: