Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MACS2 is now compatible with python3 #132

Open
IanSudbery opened this issue Nov 10, 2020 · 1 comment
Open

MACS2 is now compatible with python3 #132

IanSudbery opened this issue Nov 10, 2020 · 1 comment

Comments

@IanSudbery
Copy link
Contributor

CGATflow installation creates a separate, python2, environment for MACS. But the latest versions of MACS2 are now python3 compatible. Installing the python2 version means that we are both getting an out of date version of MACS and creating extra installation headaches.

@sebastian-luna-valero
Copy link
Member

Hi,

I agree. However, before making the change, I see that we install macs2=2.1.1.20160309:

https://github.com/cgat-developers/cgat-flow/blob/master/conda/environments/pipelines-macs2.yml#L10

which seems to be available for Python 2.7 only. If we want to install macs2 for Python 3 it will have to be a later version > 2.2.2:

https://anaconda.org/bioconda/macs2/files

Is it worth checking that a newer version of macs2 won't break existing pipelines?

For example:

Best regards,
Sebastian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants