Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: version pinning #12

Open
bmaupin opened this issue Oct 14, 2022 · 1 comment
Open

Feature request: version pinning #12

bmaupin opened this issue Oct 14, 2022 · 1 comment

Comments

@bmaupin
Copy link

bmaupin commented Oct 14, 2022

Hi,

First of all, thanks for this! I used it for quite a while, but unfortunately I had to stop using it. It always uses the latest version of htmlproofer, which is great, however due to breaking changes upstream the GitHub Action would periodically break.

It broke most recently last week when htmlproofer was upgraded to 4.4.2, which introduced a bug, and now again that htmlproofer has been upgraded to v5.

I'm honestly not sure what the best way to handle this would be, because I think it would require tagging the container image as well as the GitHub Action itself. For now I had to resort to just using this action instead: https://github.com/anishathalye/proof-html

... but that action isn't quite as nice because it's only set up with a limited number of options. I really love how this action is set up so that it is future-proof as the htmlproofer CLI parameters change.

Thanks!

@chabad360
Copy link
Owner

Creating various tags on the action for various versions could potentially work, but it is a bit complicated (for various reasons).

This action was sort of designed to be in maintenance mode from the start (hence the auto updating and such). But if you have any ideas for how I could go about doing that or even a PR, that would go a long way to making that possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants