Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: publish cmd --sbom-path not writing files #853

Merged
merged 2 commits into from
Aug 28, 2023
Merged

fix: publish cmd --sbom-path not writing files #853

merged 2 commits into from
Aug 28, 2023

Conversation

joemiller
Copy link
Contributor

fixes #804

quick fix based on the --sbom-path logic in the build cmd

@joemiller joemiller requested a review from a team as a code owner August 23, 2023 21:31
@joemiller joemiller requested review from luhring and removed request for a team August 23, 2023 21:31
@joemiller joemiller force-pushed the fix/publish-cmd-sbom-path-flag branch from b39dee6 to 2d850c7 Compare August 23, 2023 21:32
@joemiller joemiller mentioned this pull request Aug 23, 2023
Closed
@kaniini kaniini enabled auto-merge August 27, 2023 19:46
@kaniini
Copy link
Contributor

kaniini commented Aug 27, 2023

Tests need to be fixed

@joemiller
fix: publish cmd --sbom-path not writing files
37cb383 
fixes chainguard-dev#804

Signed-off-by: joe miller <joeym@joeym.net>
@joemiller
add tests to publishCmd for --sbom-path
14487c6 
Signed-off-by: joe miller <joeym@joeym.net>
auto-merge was automatically disabled August 28, 2023 22:49

Head branch was pushed to by a user without write access

@joemiller joemiller force-pushed the fix/publish-cmd-sbom-path-flag branch from 2d850c7 to 14487c6 Compare August 28, 2023 22:49
@joemiller
Copy link
Contributor Author

@kaniini oops. sorry i missed that completely 🤦

fixed the method sig in the test and also added a basic assertion that sbom files are actually written to the path

@kaniini kaniini enabled auto-merge August 28, 2023 22:53
@kaniini kaniini merged commit c1779fc into chainguard-dev:main Aug 28, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaniini kaniini kaniini approved these changes

@luhring luhring Awaiting requested review from luhring luhring was automatically assigned from chainguard-dev/images-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

apko-publish doesn't copy SBOM to local sbomPath
2 participants
@joemiller @kaniini