Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve database module #480

Open
ozankaymak opened this issue Jan 28, 2025 · 1 comment
Open

Improve database module #480

ozankaymak opened this issue Jan 28, 2025 · 1 comment
Labels
code quality Improves code quality while not affecting any other

Comments

@ozankaymak
Copy link
Contributor

Proposal Description

It needs improvements in many aspects, like how to write/read data, what to use where, etc.
@ozankaymak ozankaymak added the code quality Improves code quality while not affecting any other label Jan 28, 2025
@mmtftr
Copy link

mmtftr commented Jan 28, 2025

We’re currently duplicating a lot of code to save/get things from db using sqlx. Our database/common.rs is 1500 lines long and is hard to test and work with.
SeaORM is a sqlx-based ORM that enables Rust-based schema creation and auto-generated and type-checked queries. What about migrating from sqlx to seaorm https://www.sea-ql.org/SeaORM/?

@mmtftr mmtftr mentioned this issue Jan 28, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code quality Improves code quality while not affecting any other
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mmtftr @ozankaymak