Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change form validation for empty comments #9

Closed
chaitak-gorai opened this issue May 31, 2021 · 5 comments
Closed

Change form validation for empty comments #9

chaitak-gorai opened this issue May 31, 2021 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers Hacktoberfest

Comments

@chaitak-gorai
Copy link
Owner

At present the form validation for empty fields is comments is alert type with a page reload

Change this to Asynchronous with javascript.

Files to chanege

  • post.php

Look for includes/sidebar.php from login form for help.

@chaitak-gorai chaitak-gorai added enhancement New feature or request good first issue Good for newcomers labels May 31, 2021
@chaitak-gorai chaitak-gorai pinned this issue Oct 4, 2021
@Matteooo98
Copy link
Contributor

Hello, can i work on this ?

@chaitak-gorai
Copy link
Owner Author

yes, go ahead. I am assigning this issue to you.
Do the necessary changes to create a PR.

@chaitak-gorai
Copy link
Owner Author

chaitak-gorai commented Oct 7, 2021

Hello, @Matteooo98 we have merged your commit 9ec5ea3 and its working fine.
There are some additional changes that can be done

  • Show a message "your comment is registered, it will be shown when approved" when the comment is successful.
  • Asynchronous way will be preferred!
  • Also don't clear the form when some fields are only empty.
  • We can add "required" tag to all input fields

Also, these are open for all anyone can create a PR by solving any of the above changes.

@Matteooo98
Copy link
Contributor

okay, i work on it

@chaitak-gorai
Copy link
Owner Author

This issue is solved by #66 .Thanks, @Matteooo98 for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers Hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants