Skip to content

Commit 277a590

Browse files
authored
Add absolute transparent tokens, modify AlphaButton bg color (#2460)
<!-- How to write a good PR title: - Follow [the Conventional Commits specification](https://www.conventionalcommits.org/en/v1.0.0/). - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ## Self Checklist - [x] I wrote a PR title in **English** and added an appropriate **label** to the PR. - [x] I wrote the commit message in **English** and to follow [**the Conventional Commits specification**](https://www.conventionalcommits.org/en/v1.0.0/). - [x] I [added the **changeset**](https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md) about the changes that needed to be released. (or didn't have to) - [x] I wrote or updated **documentation** related to the changes. (or didn't have to) - [x] I wrote or updated **tests** related to the changes. (or didn't have to) - [x] I tested the changes in various browsers. (or didn't have to) - Windows: Chrome, Edge, (Optional) Firefox - macOS: Chrome, Edge, Safari, (Optional) Firefox ## Related Issue <!-- Please link to issue if one exists --> <!-- Fixes #0000 --> - 없음 ## Summary <!-- Please brief explanation of the changes made --> - bg/absolute/white,black/transparent 토큰을 추가합니다. - bg/white/white-alpha/transparent 다크테마값을 white/0에서 black/0로 수정합니다. - Alpha(Icon)Button 의 tertiary 배경색을 수정합니다. ## Details <!-- Please elaborate description of the changes --> - 생략 ### Breaking change? (Yes/No) <!-- If Yes, please describe the impact and migration path for users --> - No ## References <!-- Please list any other resources or points the reviewer should be aware of --> - [스레드(internal)](https://desk.channel.io/root/groups/v2BezierRelease-364583/6715ed6a8c9efb2632fe) - [피그마(internal)](https://www.figma.com/design/8J76noM3T1Sp5cNPhnYQiG/Action?node-id=0-1&t=GPYPLyyOBg3Oml6g-1)
1 parent 11222fb commit 277a590

File tree

6 files changed

+41
-5
lines changed

6 files changed

+41
-5
lines changed

.changeset/olive-flowers-pump.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
---
2+
'@channel.io/bezier-tokens': patch
3+
---
4+
5+
Changes in alpha functional tokens
6+
- fix value of dark theme `bg-white-white-alpha-transparent` to `black-0`.
7+
- add `bg-absolute-white,black-transparent`.

.changeset/sour-planets-burn.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@channel.io/bezier-react': patch
3+
---
4+
5+
Modify background color of tertiary `AlphaButton` and `AlphaIconButton`.

packages/bezier-react/src/components/AlphaButton/Button.module.scss

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -110,8 +110,12 @@ $chromatic-colors: 'blue', 'red', 'green', 'cobalt', 'orange', 'pink', 'purple';
110110
}
111111
}
112112

113-
&:where(.color-dark-grey, .color-light-grey, .color-white-absolute) {
114-
background-color: var(--alpha-color-bg-white-white-alpha-transparent);
113+
&:where(.color-dark-grey, .color-light-grey) {
114+
background-color: var(--alpha-color-bg-black-transparent);
115+
}
116+
117+
&:where(.color-white-absolute) {
118+
background-color: var(--alpha-color-bg-absolute-white-transparent);
115119
}
116120
}
117121

packages/bezier-react/src/components/AlphaIconButton/IconButton.module.scss

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,8 +91,12 @@ $chromatic-colors: 'blue', 'red', 'green', 'cobalt', 'orange', 'pink', 'purple';
9191
}
9292
}
9393

94-
&:where(.color-dark-grey, .color-light-grey, .color-white-absolute) {
95-
background-color: var(--alpha-color-bg-white-white-alpha-transparent);
94+
&:where(.color-dark-grey, .color-light-grey) {
95+
background-color: var(--alpha-color-bg-black-transparent);
96+
}
97+
98+
&:where(.color-white-absolute) {
99+
background-color: var(--alpha-color-bg-absolute-white-transparent);
96100
}
97101
}
98102

packages/bezier-tokens/src/alpha/functional/dark-theme/color.json

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -380,7 +380,7 @@
380380
"type": "color"
381381
},
382382
"transparent": {
383-
"value": "{color.white.0}",
383+
"value": "{color.black.0}",
384384
"type": "color"
385385
}
386386
}
@@ -780,6 +780,10 @@
780780
"lightest": {
781781
"value": "{color.black.20}",
782782
"type": "color"
783+
},
784+
"transparent": {
785+
"value": "{color.black.0}",
786+
"type": "color"
783787
}
784788
},
785789
"white": {
@@ -802,6 +806,10 @@
802806
"lightest": {
803807
"value": "{color.white.20}",
804808
"type": "color"
809+
},
810+
"transparent": {
811+
"value": "{color.white.0}",
812+
"type": "color"
805813
}
806814
}
807815
}

packages/bezier-tokens/src/alpha/functional/light-theme/color.json

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -780,6 +780,10 @@
780780
"lightest": {
781781
"value": "{color.black.20}",
782782
"type": "color"
783+
},
784+
"transparent": {
785+
"value": "{color.black.0}",
786+
"type": "color"
783787
}
784788
},
785789
"white": {
@@ -802,6 +806,10 @@
802806
"lightest": {
803807
"value": "{color.white.20}",
804808
"type": "color"
809+
},
810+
"transparent": {
811+
"value": "{color.white.0}",
812+
"type": "color"
805813
}
806814
}
807815
}

0 commit comments

Comments
 (0)