From 8c9b58cefc951288695a930927d55ec84c91aea6 Mon Sep 17 00:00:00 2001 From: "Yang Wooseong (Andrew)" Date: Mon, 23 Dec 2024 13:07:48 +0900 Subject: [PATCH] Modify the `iconColor` property of the `Banner` component to override the color. (#2575) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Self Checklist - [x] I wrote a PR title in **English** and added an appropriate **label** to the PR. - [x] I wrote the commit message in **English** and to follow [**the Conventional Commits specification**](https://www.conventionalcommits.org/en/v1.0.0/). - [x] I [added the **changeset**](https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md) about the changes that needed to be released. (or didn't have to) - [x] I wrote or updated **documentation** related to the changes. (or didn't have to) - [x] I wrote or updated **tests** related to the changes. (or didn't have to) - [x] I tested the changes in various browsers. (or didn't have to) - Windows: Chrome, Edge, (Optional) Firefox - macOS: Chrome, Edge, Safari, (Optional) Firefox ## Related Issue - resolves #2574 ## Summary - 배너의 iconColor 속성을 할당해도 variant 에 의해 정해지는 색깔을 오버라이딩하지 않는 버그를 수정합니다. ## Details - iconColor 가 없을 때만 Icon classname 을 엘리먼트에 추가하도록 했습니다. ### Breaking change? (Yes/No) - No ## References - None --- .changeset/few-singers-end.md | 5 +++++ packages/bezier-react/src/components/Banner/Banner.tsx | 4 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) create mode 100644 .changeset/few-singers-end.md diff --git a/.changeset/few-singers-end.md b/.changeset/few-singers-end.md new file mode 100644 index 0000000000..4c88375334 --- /dev/null +++ b/.changeset/few-singers-end.md @@ -0,0 +1,5 @@ +--- +'@channel.io/bezier-react': patch +--- + +Modify the `iconColor` property of the `Banner` component to override the color. diff --git a/packages/bezier-react/src/components/Banner/Banner.tsx b/packages/bezier-react/src/components/Banner/Banner.tsx index 924d5bce36..6901b34e6d 100644 --- a/packages/bezier-react/src/components/Banner/Banner.tsx +++ b/packages/bezier-react/src/components/Banner/Banner.tsx @@ -96,14 +96,14 @@ export const Banner = forwardRef(function Banner(
{isBezierIcon(icon) ? ( ) : (