From 645d079769a3e7fad866dc2832d9d26fcd3b8b45 Mon Sep 17 00:00:00 2001
From: kaloster <rkalo@contractor.chanzuckerberg.com>
Date: Tue, 10 Sep 2024 12:02:45 -0400
Subject: [PATCH] headless + args

---
 .github/workflows/compatibility_tests.yml |  5 +----
 .github/workflows/push_tests.yml          |  1 -
 client/jest-puppeteer.config.js           | 14 +++++++++-----
 3 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/.github/workflows/compatibility_tests.yml b/.github/workflows/compatibility_tests.yml
index 05aec9a96..da1a28138 100644
--- a/.github/workflows/compatibility_tests.yml
+++ b/.github/workflows/compatibility_tests.yml
@@ -82,12 +82,9 @@ jobs:
         run: |
           sudo apt-get update
           sudo apt-get install -y libhdf5-serial-dev
-          sudo apt-get install chromium-browser
       - name: Install dependencies (MacOS)
         if: startsWith(matrix.os, 'macos')
-        run: |
-          brew install --cask chromium
-          brew install hdf5
+        run: brew install hdf5
       - name: Install cellxgene from `main` branch
         if: matrix.cellxgene_build == 'main'
         run: |
diff --git a/.github/workflows/push_tests.yml b/.github/workflows/push_tests.yml
index 7b368a1bb..20a77be5c 100644
--- a/.github/workflows/push_tests.yml
+++ b/.github/workflows/push_tests.yml
@@ -99,7 +99,6 @@ jobs:
             ${{ runner.os }}-node-
       - name: Install dependencies
         run: |
-          brew install --cask chromium
           pip install setuptools
           make pydist install-dist
       - name: Smoke tests (without annotations feature)
diff --git a/client/jest-puppeteer.config.js b/client/jest-puppeteer.config.js
index 66c0b0067..f3dfa84bb 100644
--- a/client/jest-puppeteer.config.js
+++ b/client/jest-puppeteer.config.js
@@ -7,12 +7,17 @@
 const ENV_DEFAULT = require("../environment.default.json");
 
 const jestEnv = process.env.JEST_ENV || ENV_DEFAULT.JEST_ENV;
-const isHeadful =
-  process.env.HEADFUL === "true" || process.env.HEADLESS === "false";
+// const isHeadful =
+//   process.env.HEADFUL === "true" || process.env.HEADLESS === "false";
 
 const DEFAULT_LAUNCH_CONFIG = {
-  headless: !isHeadful,
-  args: ["--ignore-certificate-errors", "--ignore-ssl-errors"],
+  headless: true,
+  args: [
+    "--ignore-certificate-errors",
+    "--ignore-ssl-errors",
+    "--no-sandbox",
+    "--disable-setuid-sandbox",
+  ],
   ignoreHTTPSErrors: true,
   defaultViewport: {
     width: 1280,
@@ -26,7 +31,6 @@ const LAUNCH_CONFIG_BY_ENV = {
     headless: true,
     slowMo: 100,
     devtools: true,
-    executablePath: "/opt/homebrew/bin/chromium",
     defaultViewport: {
       width: DEFAULT_LAUNCH_CONFIG.defaultViewport.width,
       height: DEFAULT_LAUNCH_CONFIG.defaultViewport.height + 560,