Skip to content

Stop running seurat conversions as part of the SFN #7383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
joyceyan opened this issue Nov 13, 2024 · 3 comments
Closed

Stop running seurat conversions as part of the SFN #7383

joyceyan opened this issue Nov 13, 2024 · 3 comments
Assignees
@joyceyan

Comments

@joyceyan
Copy link
Contributor

No description provided.

@joyceyan joyceyan self-assigned this Nov 13, 2024
@joyceyan
Copy link
Contributor Author

#7380

@joyceyan
Copy link
Contributor Author

I believe this ticket was left in "In Progress" because we were holding off on deploying the SFN change in single-cell-data-portal until after the 5.3 migration occurred. The work for removing that from the SFN was originally in this PR which I never merged because the commit was cherry-picked and added to the feature/schema-5-3 branch of single-cell-data-portal. As far as I can tell, it doesn't seem like that branch was directly merged, but CxgSeuratParallel seems to be gone in the version of main.tf that's currently checked in to main here.

So I think we did actually deploy the change to remove Seurat conversion from the SFN, I just can't quite retrace the steps for how we got there yet.

@joyceyan
Copy link
Contributor Author

Never mind, it seems like we did merge / deploy the feature branch here: #7428

So we should be all set to close this ticket.

I'll follow up by looking into the code cleanup stragglers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joyceyan joyceyan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joyceyan